public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <gregkh@linuxfoundation.org>
To: Akshay Gujar <Akshay.Gujar@harman.com>
Cc: linux-usb@vger.kernel.org, stern@rowland.harvard.edu,
	oneukum@suse.com, linux-kernel@vger.kernel.org,
	naveen.v@harman.com, sankarkumar.krishnasamy@harman.com
Subject: Re: [PATCH v2 0/3] Generic device enumeration failure notification
Date: Wed, 7 Jan 2026 16:01:37 +0100	[thread overview]
Message-ID: <2026010726-grimy-variably-b10e@gregkh> (raw)
In-Reply-To: <20251224115808.415753-1-Akshay.Gujar@harman.com>

On Wed, Dec 24, 2025 at 11:58:05AM +0000, Akshay Gujar wrote:
> This series is a revised version of the earlier patch, updated in response
> to review feedback in the discussion starting at:
> 
>   <2025100805-resisting-target-419a@gregkh>
> 
> The intent is to provide a small, generic mechanism for notifying
> userspace when device enumeration fails after hardware is detected but
> before enumeration completes.
> 
> Some devices may be detected electrically but fail to enumerate due to
> protocol-level errors or invalid responses. Today, such failures are
> reported only via kernel log messages. This series introduces a
> structured uevent notification that allows userspace to observe these
> failures without embedding policy in the kernel.
> 
> Patch overview:
> 
>   1/3 driver-core: add device_enumeration_failure_notify() helper
>       Adds a generic helper in the driver core to emit a KOBJ_CHANGE
>       uevent containing DEVICE_ENUMERATION_FAILURE=<identifier>.
> 
>   2/3 Documentation: ABI: document DEVICE_ENUMERATION_FAILURE uevent
>       Documents the new uevent and includes an example captured on USB.
> 
>   3/3 usb: hub: send enumeration failure uevent
>       Uses the generic helper in the USB hub enumeration failure path.
> 
> The USB change is intentionally minimal and serves as an initial user of
> the generic helper. Other subsystems may use the helper independently if
> needed.
> 
> Akshay Gujar (3):
>   driver core: add device_enumeration_failure_notify() helper
>   Documentation: ABI: document DEVICE_ENUMERATION_FAILURE uevent
>   usb: hub: send enumeration failure uevent
> 
>  Documentation/ABI/testing/sysfs-uevent | 22 +++++++++++++++++++
>  drivers/base/core.c                    | 30 ++++++++++++++++++++++++++
>  drivers/usb/core/hub.c                 |  5 ++++-
>  include/linux/device.h                 | 12 +++++++++++
>  4 files changed, 68 insertions(+), 1 deletion(-)
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:

- This looks like a new version of a previously submitted patch, but you
  did not list below the --- line any changes from the previous version.
  Please read the section entitled "The canonical patch format" in the
  kernel file, Documentation/process/submitting-patches.rst for what
  needs to be done here to properly describe this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot

  parent reply	other threads:[~2026-01-07 15:01 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20250221102949.1135849-1-Akshay.Gujar@harman.com>
2025-02-21 10:53 ` [PATCH] usb: core: notify unrecognized usb device Greg KH
     [not found]   ` <20250826165244.22283-1-Akshay.Gujar@harman.com>
2025-09-06 12:28     ` Greg KH
2025-09-08  8:58       ` Oliver Neukum
2025-09-08  9:04         ` Greg KH
     [not found]       ` <20250918172355.5118-1-Akshay.Gujar@harman.com>
2025-10-08 11:08         ` Greg KH
     [not found]           ` <20251224115808.415753-1-Akshay.Gujar@harman.com>
     [not found]             ` <20251224115808.415753-2-Akshay.Gujar@harman.com>
2026-01-07 15:01               ` [PATCH v2 1/3] driver core: add device_enumeration_failure_notify() helper Greg KH
2026-01-07 15:01             ` Greg KH [this message]
     [not found]             ` <20251224115808.415753-3-Akshay.Gujar@harman.com>
2026-01-07 15:02               ` [PATCH v2 2/3] Documentation: ABI: document DEVICE_ENUMERATION_FAILURE uevent Greg KH
     [not found]             ` <20251224115808.415753-4-Akshay.Gujar@harman.com>
2026-01-07 15:03               ` [PATCH v2 3/3] usb: hub: send enumeration failure uevent Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026010726-grimy-variably-b10e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Akshay.Gujar@harman.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=naveen.v@harman.com \
    --cc=oneukum@suse.com \
    --cc=sankarkumar.krishnasamy@harman.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox