From: Xu Yang <xu.yang_2@nxp.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Michael Grzeschik <m.grzeschik@pengutronix.de>
Cc: jun.li@nxp.com, imx@lists.linux.dev, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, Xu Yang <xu.yang_2@nxp.com>
Subject: [PATCH 3/4] usb: gadget: uvc: improve error handling in uvcg_video_init()
Date: Thu, 08 Jan 2026 15:43:04 +0800 [thread overview]
Message-ID: <20260108-uvc-gadget-fix-patch-v1-3-8b571e5033cc@nxp.com> (raw)
In-Reply-To: <20260108-uvc-gadget-fix-patch-v1-0-8b571e5033cc@nxp.com>
Let uvcg_video_init() return correct code so that error can be handled
correctly.
Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
---
drivers/usb/gadget/function/uvc_video.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/usb/gadget/function/uvc_video.c b/drivers/usb/gadget/function/uvc_video.c
index b1c5c1d3e9390c82cc84e736a7f288626ee69d51..ede300190f591d39e306aecb565c614cdff5e664 100644
--- a/drivers/usb/gadget/function/uvc_video.c
+++ b/drivers/usb/gadget/function/uvc_video.c
@@ -838,7 +838,6 @@ int uvcg_video_init(struct uvc_video *video, struct uvc_device *uvc)
video->interval = 666666;
/* Initialize the video buffers queue. */
- uvcg_queue_init(&video->queue, uvc->v4l2_dev.dev->parent,
+ return uvcg_queue_init(&video->queue, uvc->v4l2_dev.dev->parent,
V4L2_BUF_TYPE_VIDEO_OUTPUT, &video->mutex);
- return 0;
}
--
2.34.1
next prev parent reply other threads:[~2026-01-08 7:42 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-08 7:43 [PATCH 0/4] Some fix patches for uvc gadget function Xu Yang
2026-01-08 7:43 ` [PATCH 1/4] usb: gadget: uvc: fix req_payload_size calculation Xu Yang
2026-01-08 15:54 ` Frank Li
2026-01-08 7:43 ` [PATCH 2/4] usb: gadget: uvc: fix interval_duration calculation Xu Yang
2026-01-08 16:04 ` Frank Li
2026-01-12 9:43 ` Xu Yang
2026-01-08 7:43 ` Xu Yang [this message]
2026-01-08 16:08 ` [PATCH 3/4] usb: gadget: uvc: improve error handling in uvcg_video_init() Frank Li
2026-01-12 9:47 ` Xu Yang
2026-01-08 7:43 ` [PATCH 4/4] usb: gadget: uvc: retry vb2_reqbufs() with vb_vmalloc_memops if use_sg fail Xu Yang
2026-01-08 16:16 ` Frank Li
2026-01-12 10:05 ` Xu Yang
2026-01-12 15:00 ` Frank Li
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260108-uvc-gadget-fix-patch-v1-3-8b571e5033cc@nxp.com \
--to=xu.yang_2@nxp.com \
--cc=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jun.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=m.grzeschik@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox