public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: pip-izony <eeodqql09@gmail.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Ingo Molnar <mingo@kernel.org>,
	Thomas Gleixner <tglx@linutronix.de>
Cc: Seungjin Bae <eeodqql09@gmail.com>,
	Kyungtae Kim <Kyungtae.Kim@dartmouth.edu>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH] usb: r8a66597-hcd: fix potential divide-by-zero in prepare_packet_read()
Date: Sat, 10 Jan 2026 14:22:33 -0500	[thread overview]
Message-ID: <20260110192233.31955-1-eeodqql09@gmail.com> (raw)

From: Seungjin Bae <eeodqql09@gmail.com>

The `prepare_packet_read()` function calculates the number of packets
required for a transfer by dividing the transfer buffer length by the
maximum packet size (`td->maxpacket`). The `td->maxpacket` is
initialized in `r8a66597_make_td()` function based on the endpoint
descriptor. However, it does not validate whether `td->maxpacket` is
zero before using it in the `DIV_ROUND_UP` macro.

If a malicious USB device sends a descriptor with `wMaxPacketSize` set to
0, it triggers a divide-by-zero exception (kernel panic).

Fix this by ensuring `td->maxpacket` is greater than 0 before performing
the division.

Fixes: 5d3043586db4 ("USB: r8a66597-hcd: host controller driver for R8A66597")
Signed-off-by: Seungjin Bae <eeodqql09@gmail.com>
---
 drivers/usb/host/r8a66597-hcd.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/r8a66597-hcd.c b/drivers/usb/host/r8a66597-hcd.c
index d21a03cf5c17..445551b4b05f 100644
--- a/drivers/usb/host/r8a66597-hcd.c
+++ b/drivers/usb/host/r8a66597-hcd.c
@@ -1097,7 +1097,7 @@ static void prepare_packet_read(struct r8a66597 *r8a66597,
 		pipe_start(r8a66597, td->pipe);
 		pipe_irq_enable(r8a66597, urb, td->pipenum);
 	} else {
-		if (urb->actual_length == 0) {
+		if (urb->actual_length == 0 && td->maxpacket > 0) {
 			pipe_irq_disable(r8a66597, td->pipenum);
 			pipe_setting(r8a66597, td);
 			pipe_stop(r8a66597, td->pipe);
-- 
2.43.0


             reply	other threads:[~2026-01-10 19:22 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-10 19:22 pip-izony [this message]
2026-01-10 20:02 ` [PATCH] usb: r8a66597-hcd: fix potential divide-by-zero in prepare_packet_read() Greg Kroah-Hartman
     [not found]   ` <CAAsoPpUv_G1Se_z9WRQ_4rHv=tiUW__eHU=03mytkdU9+kW1ag@mail.gmail.com>
2026-01-11  7:33     ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260110192233.31955-1-eeodqql09@gmail.com \
    --to=eeodqql09@gmail.com \
    --cc=Kyungtae.Kim@dartmouth.edu \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mingo@kernel.org \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox