From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f68.google.com (mail-dl1-f68.google.com [74.125.82.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 61619320A04 for ; Fri, 23 Jan 2026 08:04:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769155463; cv=none; b=rdyyemrSpNWFFhayOIYfejCz/6nyStHiXH7oSEHq8OMQET/XE35vhO7Bk9gzmQazjEx8N4F5ZhJNK1H5OF8PyxBoaxZjFq1B3D7llMPI909VfwKP/+e5YTIkim/VXBfSKl0g39QFtJ7X4tUCWsDNUCQF0Ye9qWvIlHkCWrlgVIY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769155463; c=relaxed/simple; bh=dZaT9cSBNeM285PphXlT0/xB70LYV4cXn5X4Ku0z8wY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=raTNGzuxAsHoIfOXtYh6GT/YVn7uI/xtBswoBtxgJ7SOKpCW0jQeAINNJmWysL6SEIZHnY6caRSv+726rgjk4YoNLWAOvAYFCTHu3NRt0/X2k2Z1Y8WmPyDxuXQTBdcF9yUuS9dZ+skZw1Es58dupZ7JxWXKXvDyQmML0M8mo0U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=VjqxZ/Up; arc=none smtp.client-ip=74.125.82.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="VjqxZ/Up" Received: by mail-dl1-f68.google.com with SMTP id a92af1059eb24-1233b172f02so2867415c88.0 for ; Fri, 23 Jan 2026 00:04:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1769155461; x=1769760261; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=9iUFL56beVY/iIEgFqGvI5oxeFHwKFv4+mDAz58zBhU=; b=VjqxZ/UpcakcriUiUkAdwZwlBsLwNLZTpHHvSQXevcgctZA3obknNAGHu+geIKEENi ugtxTOA2XzFyKUERGjoDA1QIbSTa9XCbRQjkIKuM8bY1pCMkzhOdXyq91bMnEn7lwQA1 aCBKTawUbWl7bADYmNxCT/pyP47+KE0fmPyJjxDyng+uJPKY9lXn7gQnorSQd09hk/Yl Mz4HAOytYjxILh2GuflFinRd730wN5BLI221u6hlGO3HAGpbk43kYxtLUHwuYqpxoWZb V/j1pDRqgiRQGTDop3jXf47gRgXZOjLSlt8idfxNiAsyhYwPiquqZKooYA9c9xv+CML3 I3Yw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769155461; x=1769760261; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=9iUFL56beVY/iIEgFqGvI5oxeFHwKFv4+mDAz58zBhU=; b=d+6+QsJsdV04OWm4adqaEhgN7ry+hkdLfeU/59JIhR7JUQI83Z3VTbDuIFfwesWDQo JwGjPnFVSNPUKc3FoY1o4rXHdhhC/M7Rc540CfKu7u4UoXt1KelpTzR6rI/4oJJ8Id20 EATBu6g5Ll9fuzlaoiX1smrIArjKWRHStnBxxGlbbAESv962NpBGNcynpJmIDE9szser s38rXbzIrA/BJ6zoXfeP2LyPz2U4E9gCUWy//YvYKUlQL1x27r6pjEQm5orP/RJqIhti x8WxRjXalujTf3Kr4M4ZrkEDAkdHXi7hR8MrCOTyfRnoN2V2RB7d24TkwcmzNh3YvgvM zutQ== X-Forwarded-Encrypted: i=1; AJvYcCVxCx/EJhfxHlCPZnWxewfhSPFP/K8u2B7jRykGTAtgu+uIuO8t4AdnJV3ky3lMdQ8GQ5SxeWM0cCw=@vger.kernel.org X-Gm-Message-State: AOJu0YxDuj8YXd1TBbgqEjasoCQoosulGR/ywjJn4e/j4SqV18c43vwg 0XgZJQM83KSqL+Yl4SM/Msn6TPevSoLHtdLn8TRRDhVJAR0QnZr4VC3E X-Gm-Gg: AZuq6aIzcAhMKsSYWyMTINRlwXo0CSqn4XEu5+PmhZ3dxb/uiNAZ95YqweDeypSn8De Xc1PXa6zMn1Q75G6cwrjx1B8Px8/KAmp0suz2pK0fhl5u+75j/ODBKsqy3t3lMp8UGAFNdfT6T2 fgHztrzkRf32k1etPN99h9kaz0fhZrca5FBNeWUaQ1CdzNMw1eIB/GRP0KrDATUNBhC7PbSGwAZ eS+ObRA0R5gedQlFpN9bIR2kC7RgmoNH1j+9Myf4KCZbiMiWuny7Hg4zKPIpa9HZ3+VCjsLd8Eo 8VmFYr/4wusj/IpRNoQmYLtfHb/XWrCxdi92gkPuuNWlQq3H2cBW0yECB+JqSPYFb2PD5INO/2t dzRuVLplmImrXRj5VLPz84Ycgh1hZwKNWZ7RlBL7KfxH7kVHSDUKK5jwdRt3khJg8NyzWQOfbP2 3IqFyni8lt2T53WMsPPawESv9R96mUPIfm8UV0UsMYTv2IzG1tE4nSjZ3YsihpAPy5H9opUXajy qy1UraCciF5XRAagtePFFVD646gjHNI9xd2zQkBzuTi/i/WYkI9DgDRQASJD+p58LVkuShpYVvQ JIrt X-Received: by 2002:a05:7022:fa8:b0:11a:335d:80d2 with SMTP id a92af1059eb24-1247dc08c24mr1070234c88.35.1769155461161; Fri, 23 Jan 2026 00:04:21 -0800 (PST) Received: from ethan-latitude5420.. (host-127-24.cafrjco.fresno.ca.us.clients.pavlovmedia.net. [68.180.127.24]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-1247d997f7bsm3395840c88.11.2026.01.23.00.04.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jan 2026 00:04:20 -0800 (PST) From: Ethan Nelson-Moore To: netdev@vger.kernel.org, linux-usb@vger.kernel.org Cc: Ethan Nelson-Moore , Andrew Lunn , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Peter Korsgaard , Simon Horman Subject: [PATCH net-next] net: usb: sr9700: rename register write commands for clarity Date: Fri, 23 Jan 2026 00:03:58 -0800 Message-ID: <20260123080409.64165-1-enelsonmoore@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit SR_WR_REG and SR_WR_REGS may be confused at a cursory glance. Rename them to be more easily differentiated to prevent this. Suggested-by: Andrew Lunn Signed-off-by: Ethan Nelson-Moore --- drivers/net/usb/sr9700.c | 8 ++++---- drivers/net/usb/sr9700.h | 4 ++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c index 9c7cd0db1768..e518e1710b18 100644 --- a/drivers/net/usb/sr9700.c +++ b/drivers/net/usb/sr9700.c @@ -37,7 +37,7 @@ static int sr_write(struct usbnet *dev, u8 reg, u16 length, void *data) { int err; - err = usbnet_write_cmd(dev, SR_WR_REGS, SR_REQ_WR_REG, 0, reg, data, + err = usbnet_write_cmd(dev, SR_WR_MULTIPLE_REGS, SR_REQ_WR_REG, 0, reg, data, length); if ((err >= 0) && (err < length)) err = -EINVAL; @@ -51,20 +51,20 @@ static int sr_read_reg(struct usbnet *dev, u8 reg, u8 *value) static int sr_write_reg(struct usbnet *dev, u8 reg, u8 value) { - return usbnet_write_cmd(dev, SR_WR_REG, SR_REQ_WR_REG, + return usbnet_write_cmd(dev, SR_WR_SINGLE_REG, SR_REQ_WR_REG, value, reg, NULL, 0); } static void sr_write_async(struct usbnet *dev, u8 reg, u16 length, const void *data) { - usbnet_write_cmd_async(dev, SR_WR_REGS, SR_REQ_WR_REG, + usbnet_write_cmd_async(dev, SR_WR_MULTIPLE_REGS, SR_REQ_WR_REG, 0, reg, data, length); } static void sr_write_reg_async(struct usbnet *dev, u8 reg, u8 value) { - usbnet_write_cmd_async(dev, SR_WR_REG, SR_REQ_WR_REG, + usbnet_write_cmd_async(dev, SR_WR_SINGLE_REG, SR_REQ_WR_REG, value, reg, NULL, 0); } diff --git a/drivers/net/usb/sr9700.h b/drivers/net/usb/sr9700.h index 3212859830dc..5c04ea0306c7 100644 --- a/drivers/net/usb/sr9700.h +++ b/drivers/net/usb/sr9700.h @@ -150,8 +150,8 @@ /* Register access commands and flags */ #define SR_RD_REGS 0x00 -#define SR_WR_REGS 0x01 -#define SR_WR_REG 0x03 +#define SR_WR_MULTIPLE_REGS 0x01 +#define SR_WR_SINGLE_REG 0x03 #define SR_REQ_RD_REG (USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE) #define SR_REQ_WR_REG (USB_DIR_OUT | USB_TYPE_VENDOR | USB_RECIP_DEVICE) -- 2.43.0