From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE06C272816; Fri, 23 Jan 2026 14:52:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769179935; cv=none; b=MtB83vV2a47uGNTcyBWq8X137P9hyokaI5LkiE+iemR7Z1HRE35HYutmDHzCsvSi55EAP6HdWqbE/EFfpFnSkzbb/tts/A0xohH+lLgMPzdbBvf3DevKhzMJImlfawo0QkbNlqJeY7jJLQVsuJpBEzEO1W2ZJZEuQXbkYi5Ly9Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769179935; c=relaxed/simple; bh=95HArh40wtcPOU5zHLV2BUqYIWkskWkANQxmuv6xw1E=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kh+nUtAtyKIKrjsd4yNfnAd187jmD5MZQ8JY5ifA9ifXvRKwLpZqksOt8sBQd4O/kKlgmcxC+ie48NnqUf5EC00qTPaerp0I/ge5vbgzL5+J2AiAYnYe6qkH5aow7rN7dgf0Hj7IfAptrehinLEYhmCb4ugbKrrjQHPHKmIKg2c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=s0rtAI4i; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="s0rtAI4i" Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB7C8C4CEF1; Fri, 23 Jan 2026 14:52:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1769179934; bh=95HArh40wtcPOU5zHLV2BUqYIWkskWkANQxmuv6xw1E=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s0rtAI4icU7Qyp7LbPkomzzmWUL/chagjmsLpIj2W60/XepwZtSihSNlMqR/54SQi dvduedT6rcmYZ5Lx7SMcU0d3DJAkAntysG6WAvnpFM5HactI/Ah2ZubtdgYbpYPs+2 s2nAn5DpYrjVm2WpbGdKB2zHgJAIqgACYaYGvL5E= Date: Fri, 23 Jan 2026 15:52:11 +0100 From: Greg Kroah-Hartman To: Jisheng Zhang Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/3] usb: gadget: Add a prefix to log messages Message-ID: <2026012339-landmine-risk-5c9c@gregkh> References: <20260123142221.14285-1-jszhang@kernel.org> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260123142221.14285-1-jszhang@kernel.org> On Fri, Jan 23, 2026 at 10:22:18PM +0800, Jisheng Zhang wrote: > I met some log as below: > [ 581.262476] read descriptors > [ 581.265558] bcdVersion must be 0x0100, stored in Little Endian order... > > To be honest, if I'm not familiar with the usb gadget framework, I dunno > which component is complaining. Add a prefix to log messages, so the > above messages will be look as below: > > [ 581.262476] usb_f_fs: read descriptors > [ 581.265558] usb_f_fs: bcdVersion must be 0x0100, stored in Little Endian order... > > Then solve similar issues for f_mass_storage and f_tcm. These should all be using the dev_info() and like calls, not pr_*(), and if that happens, then you will get the correct prefix. Can you make that change instead? thanks, greg k-h