From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A4EB03EBF37; Sun, 1 Feb 2026 07:28:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769930938; cv=none; b=Rcig8LThVADTQZTX6ansFsSVYav+7ojgATXLLSXkTejNsLwgz5vuK4ZSnSBUYaxlrtUmVaqrR+6IT11vDMjdZpTt8QJ87IB5MPzGrtMdXuc4I7XHHw0tL/5yRkjxCfH/qVlwnQoqJ9xZsEQ+QB8frgjACHzwGJIokoPonygFNlk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769930938; c=relaxed/simple; bh=EfDBxwED/eB3RlzpH7XLchId32hrv+fTHrCROCF+bq8=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UjZJMjbMW4srpFSF78KziUBaMpDOhxG5wpx4kmEn3VCyOIvBuAJ5Jzd9BcepFWmIJMO6Zkb1dKcJPKsdkVJt8lr44DfOs4Ugdyh22gFtKG6wddpKeBH5BfWpKm4t2ozsKCLMBHhyXCFiyry2/xHpQKFJyfLMggmBYrfiuMWcufQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=jPTZvZ6e; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="jPTZvZ6e" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1010C4CEF7; Sun, 1 Feb 2026 07:28:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1769930938; bh=EfDBxwED/eB3RlzpH7XLchId32hrv+fTHrCROCF+bq8=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=jPTZvZ6essDh/aD+dbd+tnh7A0TyOvUnkB3C0JqgFKprluT6yT4Ow251wSBtSAdbo Z8rhAKCFuCF6rRCcBSimbH+A6uxTIIUI1N59XTA6MP/6/L5vgkJRuGGWTO3sFyGRVY 7Mxywijfs4rwLbC8nvy4FDtk+OnweDD+m01CBzvc= Date: Sun, 1 Feb 2026 08:28:55 +0100 From: Greg Kroah-Hartman To: Krishna Kurapati Cc: Al Viro , Sam Day , Christian Brauner , Chen Ni , Mateusz Guzik , Liang Jie , Ingo Rohloff , Owen Gu , Christophe JAILLET , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] usb: gadget: Use sysfs_emit instead of sprintf Message-ID: <2026020129-given-grapple-d4ee@gregkh> References: <20260131160111.3161630-1-krishna.kurapati@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260131160111.3161630-1-krishna.kurapati@oss.qualcomm.com> On Sat, Jan 31, 2026 at 09:31:09PM +0530, Krishna Kurapati wrote: > Use sysfs_emit() instead of sprintf() in configfs attribute show functions. > sysfs_emit() is the recommended API for sysfs output as it provides buffer > overflow protection and proper formatting. But this isn't sysfs, as you say, it's configfs, so why switch? If there is no need, the churn is not required. thanks, greg k-h