From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Badhri Jagan Sridharan <badhri@google.com>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>,
Heikki Krogerus <heikki.krogerus@linux.intel.com>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: typec: tcpci: Make tcpci_pm_ops variable static
Date: Wed, 18 Feb 2026 21:56:50 +0100 [thread overview]
Message-ID: <2026021821-iodize-trolling-3bde@gregkh> (raw)
In-Reply-To: <CAPTae5Kyaems-3HEGQ8hhgkiRVPJgjecGCHQ4iRF242k+L_d8A@mail.gmail.com>
On Wed, Feb 18, 2026 at 12:35:04PM -0800, Badhri Jagan Sridharan wrote:
> On Mon, Feb 16, 2026 at 3:04 AM Krzysztof Kozlowski
> <krzysztof.kozlowski@oss.qualcomm.com> wrote:
> >
> > File-scope 'tcpci_pm_ops' is not used outside of this unit, so make it
> > static to silence sparse warning:
> >
> > tcpm/tcpci.c:1002:1: warning: symbol 'tcpci_pm_ops' was not declared. Should it be static?
> >
>
> Thanks for sending the patch Krzysztof !
> Can you also please add "Fixes:" and "Cc: stable@vger.kernel.org" ?
Why would a sparse warning fix need either of those? Are you wanting to
just pre-load my "WTF" email bot to go off? :)
thanks,
greg k-h
next prev parent reply other threads:[~2026-02-18 20:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-16 11:04 [PATCH] USB: typec: tcpci: Make tcpci_pm_ops variable static Krzysztof Kozlowski
2026-02-18 20:35 ` Badhri Jagan Sridharan
2026-02-18 20:56 ` Greg Kroah-Hartman [this message]
2026-02-18 21:02 ` Badhri Jagan Sridharan
2026-02-18 21:19 ` Greg Kroah-Hartman
2026-02-18 21:24 ` Badhri Jagan Sridharan
2026-02-18 21:01 ` Krzysztof Kozlowski
2026-02-18 21:17 ` Badhri Jagan Sridharan
2026-02-23 15:04 ` Heikki Krogerus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026021821-iodize-trolling-3bde@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=badhri@google.com \
--cc=heikki.krogerus@linux.intel.com \
--cc=krzysztof.kozlowski@oss.qualcomm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox