From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B21FE349B17; Wed, 18 Feb 2026 20:56:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771448217; cv=none; b=BEcEfPw9PzFd4uo3i5eSBqKqzYyRldWaIRaKaSbW6WenCbD8T8mHh9REqryqznFtxNyS9lTnRU9dlrM5UhOmLCjAsCucmaj9I49uMmDtDp1t0Jx/FikmswMuGZL8D76HisuI8au0mrKksGFiyxSwGBHsWLgTwdPUwszvkPp3nw4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771448217; c=relaxed/simple; bh=hvzHI9QplxYwif9r3uiA3HN4vVujEKrQGKUKEAccDpQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=D+WTQK3y7zj9KbmQoJNcH/dSzOj9SLamzS717LeFPNucu+Yw+As5ttgIOa/+KPcy7T+59LOQY2vMyEFqs3Zam3Tjs6RA+k9wMwRC0yx4d4b85hNAXIWNP3Z2Tklbb/fDmC2g0sijq1wHIsZchdZS98VPedbHBCjnbPN/whfLiKY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=QKWAR4ii; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="QKWAR4ii" Received: by smtp.kernel.org (Postfix) with ESMTPSA id E8424C116D0; Wed, 18 Feb 2026 20:56:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1771448217; bh=hvzHI9QplxYwif9r3uiA3HN4vVujEKrQGKUKEAccDpQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=QKWAR4iirx+bOjL9LeMb3PYM+D2Qv6QcATjg0qx2W2p839MjqdM3esvP44WDZZBpg BMYSnMuV4zJBVROIq8blmcmCX7lwuYPm+/slY3FYhJDn3oWCZGFDoXDF08jpAV7Gi9 FpfoMhwyzAPfMetl/HBssrQXzAwu+k9eE7bhsVwI= Date: Wed, 18 Feb 2026 21:56:50 +0100 From: Greg Kroah-Hartman To: Badhri Jagan Sridharan Cc: Krzysztof Kozlowski , Heikki Krogerus , linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] USB: typec: tcpci: Make tcpci_pm_ops variable static Message-ID: <2026021821-iodize-trolling-3bde@gregkh> References: <20260216110403.159945-2-krzysztof.kozlowski@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Wed, Feb 18, 2026 at 12:35:04PM -0800, Badhri Jagan Sridharan wrote: > On Mon, Feb 16, 2026 at 3:04 AM Krzysztof Kozlowski > wrote: > > > > File-scope 'tcpci_pm_ops' is not used outside of this unit, so make it > > static to silence sparse warning: > > > > tcpm/tcpci.c:1002:1: warning: symbol 'tcpci_pm_ops' was not declared. Should it be static? > > > > Thanks for sending the patch Krzysztof ! > Can you also please add "Fixes:" and "Cc: stable@vger.kernel.org" ? Why would a sparse warning fix need either of those? Are you wanting to just pre-load my "WTF" email bot to go off? :) thanks, greg k-h