From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f195.google.com (mail-pf1-f195.google.com [209.85.210.195]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A783230BBBF for ; Tue, 24 Feb 2026 07:33:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.195 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771918384; cv=none; b=u/uy1rBjPBXIYFXxdBAp1Toc5b8xdqd38rtsKcipU7PBEAhYYVm8xHcm9TCfr8wW3F7cvLTMXVFDRctPO/O3rNb87F0WYCqW5FLzY/VtFCfS+MT8oGxwSCl/BjyXTuyOaTa6klP7a6Ra1hpfykGQo82qoddRq3r5aV7yl+DkjNY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1771918384; c=relaxed/simple; bh=dGJkN6SnVshmKW6KFF4UVx9o8lSkn1Lt8gx8YuivxlU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=EKOixeBQaKj9iGa4Dq0uDpHY4ygpDc5d9RrLG8f9m9RMzDGKgrwvFtsJ49Do3OYTp1vFMvvLdX9iaCnuY6VnhmTZv66eHJR1YjgQSoyw1ko7h/7KWn49lR+hQUsVLhdcUKIJ9SxT/zKOuy9v8HebDxbWaDdej0cY9qS77MPi6F4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IpCXJcaA; arc=none smtp.client-ip=209.85.210.195 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IpCXJcaA" Received: by mail-pf1-f195.google.com with SMTP id d2e1a72fcca58-8220bd582ddso2348837b3a.2 for ; Mon, 23 Feb 2026 23:33:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771918383; x=1772523183; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=1j2htuqmQpTTkLQ6035xROAKmDGpEfPVgSnXewPmtLo=; b=IpCXJcaAK7k0hT6f4MwikAdkW+l7zxShjxPvEpC2htMGtQOgaqMZnr9giLDTsH//fh ytpldfUj2cs1t5mPEL0aAFrtfK2epgtX/P/grDXIPEeMyvrwB92m0cTdjlyVJp8OuTsH e9wSN8MrRR33M4Q8JbNG1visBoAv2rXgIeoMHemWBZgPTMpf2lVWk1NSt3Wp5jnQ8Vrk Aqu+I6jWvxqkepKcXWCCUuOf53K5gMIwOCKs8G3XDXvM1n9n1C7ka4tDqAi7plMfey6J 71uWVrmzb3LG6eVaOJsBu9jC3wbL9KmXrq2tpqBxk7OatCdP0btoxj/5zwOBNttxfFuw Ay2g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771918383; x=1772523183; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=1j2htuqmQpTTkLQ6035xROAKmDGpEfPVgSnXewPmtLo=; b=Vm2KXh0AotzS6Z5IocHrnfVNVAYlSfyFD1nXguViMyxptrePhrkC4XgSGGkQG7ji5Q caFFi0vp0+Gw5WsgBr3SgouxEs+qzaAx55e4UH1JoW1r9j4JH77Rs4hw9Bd49Fb1IW4q jOqShWQcbehYJRkCUarAB02953YZaSXG5dIpZyxMGh2PW27arQYZkFvgUfmtsPXwvdKH l2WmIC7nxg8Iw3obEy2E3yw2UcWywx+beGzG4NSucTPCHdpTl1BkQXFDWrwwDgTf+hTt Bn76QQipIRzXHVpGLNgnveuNByLRTKwz0iSlRH39+BEMJ8klnuUPeMbc9o9S8u1MjRtj yJHA== X-Forwarded-Encrypted: i=1; AJvYcCVkVFUNmgDp0EnFkwEI78xFm4zxSJddJYi+/+VlQdhM5lsVXU2as1WcYawTQjbne62wvHI8slzDvvU=@vger.kernel.org X-Gm-Message-State: AOJu0YwAioSncEB9Wnc8QM4OgjcnIa35+pJV1Al7BF6QM/bIaj535Eiz JfRdLM0+bbPq6osEwi1k+z1+/t0PUfu1DePseyF4EXP4yaQt5rHCaU0B X-Gm-Gg: ATEYQzy2nMNx1PRWS0Ws4b5ID+v+1cFR8CCP1czvl5m+eLhl3VrPrvJSDIkYFSvmah/ Pl/FjxZldUk7o4eH+98EoYvcHyA1dMeZe/zRyCRLd4EAEaLCDVxbm2G8FLmDJT9BKbJhN2MVvYl JojtwfVpblsIsHtXeFgwtCQun6TvBi6154Nq6HqkU2uynzJxsfk2VfPceYu67nQXSwxl30Hu6pw JZOLFAi/Yvq069hB5JYFgz2nWKeE2sPgTe9rn1zzbH8ExcTTyBU6aU3wkjwgtCCwQDd90LcIWYq QsAFs4gc8BfJC33qmalYFWdh2mmmlQ9wxtC2yt/aCHTSDAJxf6uSigDzPjPwWmc3UnXtEhjltTZ 8/puQ0efatILUGg6eqaKxCeGzI/qsmJbWKaFE3z+KhbNttOeQsRjVMnyBcbVo18iRS2GfLzx0n8 sjKUjtobwJSkkX6kCgf0jLTRP+0exs66VEbiirsYMlkUjcqUh6XZO0lSV24PnQMSIlukBw X-Received: by 2002:a05:6a00:2886:b0:81f:4294:6080 with SMTP id d2e1a72fcca58-826da8f1ab5mr11354487b3a.20.1771918383031; Mon, 23 Feb 2026 23:33:03 -0800 (PST) Received: from zeeshan-Standard-PC-Q35-ICH9-2009.. ([110.93.227.54]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-826dd8cbb02sm9994587b3a.57.2026.02.23.23.32.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 23 Feb 2026 23:33:02 -0800 (PST) From: Zeeshan Ahmad To: Thinh Nguyen , Greg Kroah-Hartman Cc: Dan Carpenter , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Zeeshan Ahmad Subject: [PATCH] usb: dwc3: qcom: simplify error check in dwc3_qcom_find_num_ports() Date: Tue, 24 Feb 2026 12:32:43 +0500 Message-ID: <20260224073243.9053-1-zeeshanahmad022019@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The platform_get_irq_byname_optional() function returns a non-zero IRQ number on success and a negative error code on failure. It never returns zero. The current implementation in the modern dwc3-qcom driver checks for a return value less than or equal to zero. Since zero is not a valid return value, simplify the check to only look for negative error codes. This aligns the logic with the standard return contract of the platform IRQ APIs. Signed-off-by: Zeeshan Ahmad --- drivers/usb/dwc3/dwc3-qcom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index 9ac75547820d..f43f73ac36ff 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -526,14 +526,14 @@ static int dwc3_qcom_find_num_ports(struct platform_device *pdev) int irq; irq = platform_get_irq_byname_optional(pdev, "dp_hs_phy_1"); - if (irq <= 0) + if (irq < 0) return 1; for (port_num = 2; port_num <= DWC3_QCOM_MAX_PORTS; port_num++) { sprintf(irq_name, "dp_hs_phy_%d", port_num); irq = platform_get_irq_byname_optional(pdev, irq_name); - if (irq <= 0) + if (irq < 0) return port_num - 1; } -- 2.43.0