From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84A9A2D3A86 for ; Wed, 25 Feb 2026 06:43:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.68 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772001796; cv=none; b=NyrXhmB2EI9nRA8cTEs3Bc5ECQvVDfb3Ozh2du9PpvWr/9K29MftAZndGC8fXrpvkU/C/g/8p0NGmNnaZkvVfUfi9FLCiPDXDRW4exEKDEkVib0sJhuDi1CptYuNe+YRbGmoZDR72TvWpiO3LpnNKr6Raq2smMQwrcwYnvgFPk8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772001796; c=relaxed/simple; bh=dGJkN6SnVshmKW6KFF4UVx9o8lSkn1Lt8gx8YuivxlU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GzqojfRwFJDVNJc5swi7aEHL9aPcsJsLbefjYoQTrqw9r75zievnGMwT6pXfk71Voe4QqaiJB7J9RTv7owt8Y3kcvwee15VL7gkDCPXqBn7nNldLpRXH40G0LNxT8NZPRu5v2Drc48m1+l7gDnvvU9PYXNAU3q+H2fBx2szLkGw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=TAXANip5; arc=none smtp.client-ip=209.85.221.68 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="TAXANip5" Received: by mail-wr1-f68.google.com with SMTP id ffacd0b85a97d-43767807cf3so4677144f8f.1 for ; Tue, 24 Feb 2026 22:43:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1772001793; x=1772606593; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=1j2htuqmQpTTkLQ6035xROAKmDGpEfPVgSnXewPmtLo=; b=TAXANip539EJa5cTLIFPeinn+cIjUHCMCNoq4l21gl+9a7ZGhyXTDWWaYvQOPkpTiC rhXOpZYgzs0817cpO+27SzJ4PF0+8cm0P6gEO5SNg54Q/s6md8m2ww+UNghYXXCYaHK2 +qdJkQPHfOoRxTZ/n2dH+ZLMHBaRiIkkRiigFzJIwEmMxvEIsth6+AW0PJ2r3YXXKazo oNXdgMv/q1gT4deJhU1YQRqt5nXkuta3rRFHreEy49/YJwEirrNBqBoiwCA6+dhjBsxQ /r9m3ng1qrLCVXovA9k29IsiX2eWR8bVgV36+ndRZPg1Rt8LPl92M9rY1KD42CMCxbnY bazA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1772001793; x=1772606593; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=1j2htuqmQpTTkLQ6035xROAKmDGpEfPVgSnXewPmtLo=; b=VB3T/57dZRElYNXbbMldvf35N8pzJHiQgfoZ2QeCGpaMrAiEnSB3RGOrLYHbYZNHL0 c5h7Wo8E8soi+IUqI1EJTRU89DSAP87a74/df67LhL/H2uiqPljikBZvHBz6v89xVL+q 5+ID0KokZywoV5C9s1Mb4yMbMnsVI+C+GM2NPQsXemSgjHyENHU5iVrOwQZCsnzcbINB /ob55AeFqijcX5nzd3ANs2lzvpIpEwvkIDBiBJXtNr3TttpOF2JfuVspLXaoba/dX1ys DGwvxob7yUcryYh42LmEHZncf+lhe6blBOOUfjII8VFqG1yOhO/4aSAakqDefbKGp0nd lX7Q== X-Forwarded-Encrypted: i=1; AJvYcCWdON42zxRhNATsdKQrh5rwCzU+fUQ5SS1MSRVKHk7+nt+gk+OWCU1nh+nJ66Vng1IBUBb4eRtaRiw=@vger.kernel.org X-Gm-Message-State: AOJu0YyXJufO9b0r1iEOauswJIbhAoygmXcRpuVQ9cNrq9VXZrH2JqCu +ZzUoRMBFSE2HKs7Nc37MbrlbFBFnAbj4rHKwTzptuS6SFq7n+kWhW/q X-Gm-Gg: ATEYQzywxvrH4efiGBNYlVZwrN3p1/CR/+nILYAhtFCqv0Kiuln/dDxyVUUO/NS/XP2 6NxmZLIruzYVWVcwm/ToLCL8+XnCpxh3oUiJxPmEnXJb/Y6Fgsw6011pQbWRgUopibG8DGzGBmm EX2Hz0MIlDJsdzCGvRIvJcVORBenFjUczc+1yttqhWrCCXIH82atPl9FdNZFBltuoABhuCSopM6 LVFw4OFQgNBMfk0xvqZn+fthsLqHTSdh15PqfineFtYuTTabM8DeDgonImV7VV1Hn9tO2zEZg2T MphxQLE2YnNJVve+DIT64o66Tj7DIIc2LItvNb2w/MvaOkHDDYIw9Sb0mOIClJWld+ivr2LEjNC rW7QSjX2urNGl5vfX5UGtY/VMWisqHnIdjcJ5GiOyK5frZM7VwaH2MBNdy/uDY7yIyp4+92neDr l2c2yKkA4mo4vbrlXYm6ttRJkUBzUQ2ptstA/PrJtBm3WYURJR9r4+XJMWy9zgq0vnpr8P X-Received: by 2002:a05:6000:26c6:b0:437:7168:af4f with SMTP id ffacd0b85a97d-4398faf1376mr1688051f8f.27.1772001792676; Tue, 24 Feb 2026 22:43:12 -0800 (PST) Received: from zeeshan-Standard-PC-Q35-ICH9-2009.. ([110.93.227.54]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-43987f3ed03sm10954287f8f.16.2026.02.24.22.43.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 24 Feb 2026 22:43:12 -0800 (PST) From: Zeeshan Ahmad To: Thinh Nguyen , Greg Kroah-Hartman Cc: Dan Carpenter , linux-usb@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org, Zeeshan Ahmad Subject: [PATCH v2] usb: dwc3: qcom: simplify error check in dwc3_qcom_find_num_ports() Date: Wed, 25 Feb 2026 11:42:45 +0500 Message-ID: <20260225064245.8833-1-zeeshanahmad022019@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260225001036.gg2ghnayekrhbcxh@synopsys.com> References: <20260225001036.gg2ghnayekrhbcxh@synopsys.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The platform_get_irq_byname_optional() function returns a non-zero IRQ number on success and a negative error code on failure. It never returns zero. The current implementation in the modern dwc3-qcom driver checks for a return value less than or equal to zero. Since zero is not a valid return value, simplify the check to only look for negative error codes. This aligns the logic with the standard return contract of the platform IRQ APIs. Signed-off-by: Zeeshan Ahmad --- drivers/usb/dwc3/dwc3-qcom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c index 9ac75547820d..f43f73ac36ff 100644 --- a/drivers/usb/dwc3/dwc3-qcom.c +++ b/drivers/usb/dwc3/dwc3-qcom.c @@ -526,14 +526,14 @@ static int dwc3_qcom_find_num_ports(struct platform_device *pdev) int irq; irq = platform_get_irq_byname_optional(pdev, "dp_hs_phy_1"); - if (irq <= 0) + if (irq < 0) return 1; for (port_num = 2; port_num <= DWC3_QCOM_MAX_PORTS; port_num++) { sprintf(irq_name, "dp_hs_phy_%d", port_num); irq = platform_get_irq_byname_optional(pdev, irq_name); - if (irq <= 0) + if (irq < 0) return port_num - 1; } -- 2.43.0