Re: [PATCH] usb: dwc3: Support for USB3340x ULPI PHY, via "snps,enable_xcvrdly_quirk"

[Ingo Rohloff <ingo.rohloff@lauterbach.com>]

Hello Thinh,

Thank you for being patient!

I still don't really understand, or maybe there is a general
misunderstanding.

> On Thu, Feb 26, 2026, Ingo Rohloff wrote:
> > Do you mean to read in a dwc3_xlnx_driver specific device tree property
> > and then pass this via software node to the main DWC3 driver?  
> 
> Not some device tree property, but the compatible string for your
> specific platform.

I am not sure what "platform" means here:

My platform is a custom made PCB my company manufactures,
which is part of a product we sell.

On this PCB is a Xilinx Ultrascale+ ZynqMP chip connected to
a Microchip USB3340 chip (and of course more non USB related chips).

The dwc3_xlnx_of_match[] in drivers/usb/dwc3/dwc3-xilinx.c 
lists only these two devices, which are FPGAs from Xilinx.


	{
		.compatible = "xlnx,zynqmp-dwc3",
		.data = &dwc3_xlnx_init_zynqmp,
	},
	{
		.compatible = "xlnx,versal-dwc3",
		.data = &dwc3_xlnx_init_versal,
	}

We use the first entry "xlnx,zynqmp-dwc3".

Do you mean these entries, when you say "platform" ?


I could add a
	{
		.compatible = "lauterbach,powerdebug-v1-zynqmp-dwc3",
		.data = &dwc3_xlnx_init_zynqmp,
	},

and then use this "compatible" match to pass a property
to the DWC3 driver to set the XCVRDLY bit.

But this particular entry then refers to some
completely specific PCB from my company, which is not publicly
available (except as part of the product we sell).

I don't think that you mean I should add another entry to
dwc3_xlnx_of_match[] ?

So I still don't understand to which "compatible" string you refer to.


with best regards
  Ingo

-- 


-------------------------------------------------------------------------
Dipl.-Inform.
Ingo ROHLOFF
Senior Staff Embedded Systems Engineering
phone +49 8102 9876-142 - ingo.rohloff@lauterbach.com

Lauterbach Engineering GmbH & Co. KG
Altlaufstrasse 40, 85635 Hoehenkirchen-Siegertsbrunn, GERMANY
www.lauterbach.com

Registered Office: Hoehenkirchen-Siegertsbrunn, Germany,
Local Court: Munich, HRA 87406, VAT ID: DE246770537,
Managing Directors: Lothar Lauterbach, Stephan Lauterbach, Dr. Thomas
Ullmann

-------------------------------------------------------------------------