Linux USB
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Peter Chen <peter.chen@cixtech.com>
Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	 gregkh@linuxfoundation.org, pawell@cadence.com,
	rogerq@kernel.org,  devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org,
	 cix-kernel-upstream@cixtech.com
Subject: Re: [PATCH 2/2] dt-bindings: usb: cdns,usb3: Add support for USBSSP
Date: Mon, 2 Mar 2026 08:29:40 +0100	[thread overview]
Message-ID: <20260302-sly-shrewd-wasp-fbda1d@quoll> (raw)
In-Reply-To: <20260302030339.324196-3-peter.chen@cixtech.com>

On Mon, Mar 02, 2026 at 11:03:34AM +0800, Peter Chen wrote:
> Extend the Cadence USBSS DRD binding to also cover the USBSSP
> controller by adding "cdns,usbssp" to the compatible enum.

So here you explan what you did

> 
> The USBSSP is the next-generation Cadence USB controller IP. It adds
> SuperSpeed Plus (USB 3.1 gen2x1, 10 Gbps) support and uses an
> XHCI-based device controller. The register layout and resource model
> (otg/xhci/dev memory regions; host/peripheral/otg interrupts) are
> identical to the USBSS, so both controllers share the same binding

Heh, identical but completely incompatible. If you are using Claude then
at least read its feedback - what does it say when devices are 100%
compatible?

> and the same platform driver (cdns3-plat.c).
> 
> Changes to the binding:

And here. How many times more?

> - compatible: const -> enum with cdns,usb3 and cdns,usbssp
> - maximum-speed: add super-speed-plus
> - Add USBSSP example

Pointless. Explain WHY are you doing this, why do we even want this
generic compatible, not paste here Claude microslop output.

Best regards,
Krzysztof


  parent reply	other threads:[~2026-03-02  7:29 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-02  3:03 [PATCH 0/2] usb: cdns3: USBSSP platform driver support Peter Chen
2026-03-02  3:03 ` [PATCH 1/2] usb: cdns3: Add " Peter Chen
2026-03-02  7:31   ` Krzysztof Kozlowski
2026-03-02 11:05     ` Peter Chen
2026-03-04 23:07   ` kernel test robot
2026-03-04 23:29   ` kernel test robot
2026-03-08 11:38   ` kernel test robot
2026-03-11  6:52   ` Pawel Laszczak
2026-03-02  3:03 ` [PATCH 2/2] dt-bindings: usb: cdns,usb3: Add support for USBSSP Peter Chen
2026-03-02  7:28   ` Krzysztof Kozlowski
2026-03-02  9:21     ` Peter Chen
2026-03-02  9:27       ` Krzysztof Kozlowski
2026-03-02 10:59         ` Peter Chen
2026-03-04 10:02           ` Pawel Laszczak
2026-03-11 12:02             ` Peter Chen
2026-03-12  8:07               ` Pawel Laszczak
2026-03-02  7:29   ` Krzysztof Kozlowski [this message]
2026-03-02  9:33     ` Peter Chen
2026-03-02  9:03   ` Pawel Laszczak
2026-03-02 11:04     ` Peter Chen
2026-03-03  7:34 ` [PATCH 0/2] usb: cdns3: USBSSP platform driver support Pawel Laszczak
2026-03-03 10:54   ` Peter Chen
2026-03-04  8:22     ` Pawel Laszczak
2026-03-04  8:31       ` Peter Chen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260302-sly-shrewd-wasp-fbda1d@quoll \
    --to=krzk@kernel.org \
    --cc=cix-kernel-upstream@cixtech.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=pawell@cadence.com \
    --cc=peter.chen@cixtech.com \
    --cc=robh@kernel.org \
    --cc=rogerq@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox