From: Greg KH <gregkh@linuxfoundation.org>
To: Pengpeng Hou <pengpeng.hou@isrc.iscas.ac.cn>
Cc: peter.chen@kernel.org, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, 18291782795@163.com
Subject: Re: [PATCH] usb: chipidea: scope ci_ulpi_resume() to CONFIG_PM
Date: Wed, 11 Mar 2026 15:18:58 +0100 [thread overview]
Message-ID: <2026031109-hardhat-dispersed-6b5c@gregkh> (raw)
In-Reply-To: <20260309084523.718431-1-pengpeng.hou@isrc.iscas.ac.cn>
On Mon, Mar 09, 2026 at 08:45:23AM +0000, Pengpeng Hou wrote:
> In current linux.git (1954c4f01220), ci_ulpi_resume() is defined
No need to reference the tree like this, that's not the normal way.
> and declared unconditionally. However, its only in-tree caller is within
> ci_controller_resume() in drivers/usb/chipidea/core.c, which is already
> guarded by #ifdef CONFIG_PM.
>
> Match the helper scope to its caller by wrapping the definition in
> CONFIG_PM and providing a no-op stub in the header. This fixes the
> config-scope mismatch and avoids unnecessary code inclusion when
> power management is disabled.
How much does this actually save? Why is only resume() needed to be
#ifdef here, not suspend?
thanks,
greg k-h
prev parent reply other threads:[~2026-03-11 14:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-09 8:45 [PATCH] usb: chipidea: scope ci_ulpi_resume() to CONFIG_PM Pengpeng Hou
2026-03-11 14:18 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026031109-hardhat-dispersed-6b5c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=18291782795@163.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pengpeng.hou@isrc.iscas.ac.cn \
--cc=peter.chen@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox