From: Greg KH <gregkh@linuxfoundation.org>
To: Zongmin Zhou <min_halo@163.com>
Cc: valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Zongmin Zhou <zhouzongmin@kylinos.cn>
Subject: Re: [PATCH] usbip: tools: Add usbip host driver availability check
Date: Wed, 11 Mar 2026 13:13:26 +0100 [thread overview]
Message-ID: <2026031146-battery-ripcord-02f6@gregkh> (raw)
In-Reply-To: <20260303081720.84868-1-min_halo@163.com>
On Tue, Mar 03, 2026 at 04:17:20PM +0800, Zongmin Zhou wrote:
> From: Zongmin Zhou <zhouzongmin@kylinos.cn>
>
> Currently, usbip_generic_driver_open() doesn't verify that the required
> kernel module (usbip-host or usbip-vudc) is actually loaded.
> The function returns success even when no driver is present,
> leading to usbipd daemon run success without driver loaded.
>
> So add a check function to ensure usbip host driver has been loaded.
>
> Signed-off-by: Zongmin Zhou <zhouzongmin@kylinos.cn>
> ---
> tools/usb/usbip/libsrc/usbip_device_driver.c | 2 ++
> tools/usb/usbip/libsrc/usbip_host_common.c | 31 ++++++++++++++++++++
> tools/usb/usbip/libsrc/usbip_host_common.h | 2 ++
> tools/usb/usbip/libsrc/usbip_host_driver.c | 2 ++
> 4 files changed, 37 insertions(+)
>
> diff --git a/tools/usb/usbip/libsrc/usbip_device_driver.c b/tools/usb/usbip/libsrc/usbip_device_driver.c
> index 927a151fa9aa..6da000fab26d 100644
> --- a/tools/usb/usbip/libsrc/usbip_device_driver.c
> +++ b/tools/usb/usbip/libsrc/usbip_device_driver.c
> @@ -147,6 +147,8 @@ static int usbip_device_driver_open(struct usbip_host_driver *hdriver)
> struct usbip_host_driver device_driver = {
> .edev_list = LIST_HEAD_INIT(device_driver.edev_list),
> .udev_subsystem = "udc",
> + .bus_type = "platform",
I think the "bus type" is changing in newer kernel versions, so be
careful about attempting to hard-code anything like this. Devices can
move around between bus types just fine, that is not how they should
ever be referenced.
thanks,
greg k-h
next prev parent reply other threads:[~2026-03-11 12:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-03 8:17 [PATCH] usbip: tools: Add usbip host driver availability check Zongmin Zhou
2026-03-10 22:28 ` Shuah Khan
2026-03-12 2:17 ` Zongmin Zhou
2026-03-23 19:17 ` Shuah Khan
2026-03-25 2:26 ` [PATCH v2] " Zongmin Zhou
2026-03-25 8:58 ` Greg KH
2026-03-26 3:10 ` Zongmin Zhou
2026-03-26 8:43 ` Greg KH
2026-03-26 18:43 ` Shuah Khan
2026-03-27 8:39 ` Zongmin Zhou
2026-03-27 17:51 ` Shuah Khan
2026-03-27 18:29 ` Shuah Khan
2026-03-30 3:10 ` Zongmin Zhou
2026-03-11 12:13 ` Greg KH [this message]
2026-03-12 2:17 ` [PATCH] " Zongmin Zhou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026031146-battery-ripcord-02f6@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=min_halo@163.com \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
--cc=zhouzongmin@kylinos.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox