From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCBC83750D3; Fri, 13 Mar 2026 12:45:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773405956; cv=none; b=c6f7tmzwj13uVL0V+9oznSJhbro5yYQHM9GK1XrFlizq0hH7XpmJGAQq2OUQQmYsg1N3waxXjQMh4WE4ZyNmVztx7CfmBK/HpSjQSB9BLbzLlk+ePVg0PMZa06+PEcA6rvSoHxL1TcIp+cqhoKfVfoiTs/nXi47b7uL2PzCT98U= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773405956; c=relaxed/simple; bh=fBuS9ncfG7ZvEfsT5w8lBatDvpOW603wmlOUfj5Sr+A=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=lqEBaKQp8Z29jyEqsf4edMrprUmqIzJY3upMWPp+2/rl2obErOaTCow8Vlibmzx8upQyERlXJm5TymQRvCck0VvcocGB6aok4KiNfZYAc7K3T6POfXnXSRmibEbHBcoD2OeNGUd8D2Q5kG6wwzMfVGw3GzZmBvtj/yXCBro5mQQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=SCYzGSRp; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="SCYzGSRp" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0015C19421; Fri, 13 Mar 2026 12:45:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773405955; bh=fBuS9ncfG7ZvEfsT5w8lBatDvpOW603wmlOUfj5Sr+A=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SCYzGSRpIg/yBSR8wq2vAcrV+WkgbDh8OwCbc0FswlSxwLBV6tUZeX8qeApf4cJbj nE79oAGg1TcGyGKbTmW+Mefid/z4b+yvlj+HQfDFkCjW2aw3aj6s7HonU8AKXe+zZT y0g4wR7UN682mIC0cV5GiVNaY4H4V5JMqzHu99MQ= Date: Fri, 13 Mar 2026 13:45:50 +0100 From: Greg Kroah-Hartman To: Konrad Dybcio Cc: Elson Serrao , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Souradeep Chowdhury , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH RFC v3 02/10] usb: misc: qcom_eud: add sysfs attribute for port selection Message-ID: <2026031327-sugar-disfigure-8034@gregkh> References: <20260309203337.803986-1-elson.serrao@oss.qualcomm.com> <20260309203337.803986-3-elson.serrao@oss.qualcomm.com> <2026031101-cornstalk-partner-a30e@gregkh> <6fe7a63c-a1b3-430b-a128-0e38754d6393@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6fe7a63c-a1b3-430b-a128-0e38754d6393@oss.qualcomm.com> On Fri, Mar 13, 2026 at 01:10:10PM +0100, Konrad Dybcio wrote: > On 3/11/26 2:16 PM, Greg Kroah-Hartman wrote: > > On Mon, Mar 09, 2026 at 01:33:29PM -0700, Elson Serrao wrote: > >> EUD can be mapped to either the primary USB port or the secondary USB port > >> depending on the value of the EUD_PORT_SEL register. Add a 'port' sysfs > >> attribute to allow userspace to select which port EUD should operate on > >> and update the ABI documentation. This is needed for systems with dual > >> USB ports where EUD needs to be accessible on either port depending on the > >> system configuration and use case. > >> > >> Signed-off-by: Elson Serrao > >> --- > >> Documentation/ABI/testing/sysfs-driver-eud | 16 ++++++++ > >> drivers/usb/misc/qcom_eud.c | 43 ++++++++++++++++++++++ > >> 2 files changed, 59 insertions(+) > >> > >> diff --git a/Documentation/ABI/testing/sysfs-driver-eud b/Documentation/ABI/testing/sysfs-driver-eud > >> index 2bab0db2d2f0..67223f73ee60 100644 > >> --- a/Documentation/ABI/testing/sysfs-driver-eud > >> +++ b/Documentation/ABI/testing/sysfs-driver-eud > >> @@ -7,3 +7,19 @@ Description: > >> EUD based on a 1 or a 0 value. By enabling EUD, > >> the user is able to activate the mini-usb hub of > >> EUD for debug and trace capabilities. > >> + > >> +What: /sys/bus/platform/drivers/qcom_eud/.../port > >> +Date: January 2026 > >> +Contact: Elson Serrao > >> +Description: > >> + Selects which USB port the Embedded USB Debugger (EUD) > >> + is mapped to on platforms providing multiple High-Speed > >> + USB ports. > >> + > >> + Valid values: > >> + 0 - Primary USB port > >> + 1 - Secondary USB port > > > > Why not use "primary" and "secondary" as values instead? That makes > > this much simpler to understand. > > It's not inconceivable that future iterations of this hardware will let > one mux between more than two USB PHYs/ports (there are already a multitude > of SoCs where we have 4 or more USB controllers and >= that ports) Great, and how will that be defined? As a number? Name? Something else? thanks, greg k-h