From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Bence Csókás" <bence98@sch.bme.hu>
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] USB: core: Use `krealloc()` in `usb_cache_string()`
Date: Sun, 15 Mar 2026 10:47:34 +0100 [thread overview]
Message-ID: <2026031500-speak-lying-2626@gregkh> (raw)
In-Reply-To: <d3da22c8-bef2-49cf-b4fe-0936ef8e42db@sch.bme.hu>
On Sun, Mar 15, 2026 at 10:40:48AM +0100, Bence Csókás wrote:
> > Also, how was this tested?
>
> I just compiled and booted it on my Arch box (with the original vendor
> config), an AthlonII X2 PC. I'm now typing this mail on a USB keyboard and
> mouse under Plasma, running this kernel :) I also plugged in a pendrive,
> mounted it, `ls`'d the mount, unmounted, unplugged, and did this 2 more
> times.
>
> I realize I should probably put this info under the dashes. I'll prepare a
> v2.
Try looking at the USB strings in the device, as that's the path here
that is exercised. Just using the device doesn't actually grab them
from the descriptor table.
And sorry for the extra review, I'm a bit picky about this function, it
was my first contribution to Linux way back in 1999 or so, and happen to
know too much about USB descriptor strings :)
thanks,
greg k-h
next prev parent reply other threads:[~2026-03-15 9:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-11 23:06 [PATCH] USB: core: Use `krealloc()` in `usb_cache_string()` Bence Csókás via B4 Relay
2026-03-12 5:02 ` Greg Kroah-Hartman
2026-03-15 9:40 ` Bence Csókás
2026-03-15 9:47 ` Greg Kroah-Hartman [this message]
2026-03-15 9:59 ` Bence Csókás
2026-03-15 10:34 ` Bence Csókás
2026-03-15 10:47 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026031500-speak-lying-2626@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=bence98@sch.bme.hu \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox