public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Edward Blair <edward.blair@gmail.com>
To: heikki.krogerus@linux.intel.com
Cc: linux-usb@vger.kernel.org
Subject: Re: [PATCH 2/2] usb: typec: ucsi: add ITE885x I2C transport driver
Date: Mon, 16 Mar 2026 15:01:28 +0000	[thread overview]
Message-ID: <20260316150128.30203-1-edward.blair@gmail.com> (raw)
In-Reply-To: <abgaax86_52szWnr@kuha>

On Mon, 16 Mar 2026 at 16:57, Heikki Krogerus wrote:
> Besides the above comment, this looks okay to me.
>
> But couldn't you use the resource managed version to request the
> irq: devm_request_threaded_irq() ?

Thanks for the review. Will switch to devm_request_threaded_irq()
and update the header comment for v2. As you noted on patch 1/2,
MSFT8000 is RhProxy, not generic UCSI.

Thanks,
Edward

      reply	other threads:[~2026-03-16 15:01 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-14  1:31 [PATCH 0/2] Add UCSI I2C transport driver for ITE885x USB-C controllers Edward Blair
2026-03-14  1:31 ` [PATCH 1/2] i2c: acpi: skip generic I2C device when vendor-specific sibling exists Edward Blair
2026-03-16 13:12   ` Mika Westerberg
2026-03-16 14:32     ` Edward Blair
2026-03-16 14:45       ` Mika Westerberg
2026-03-16 15:04         ` Edward Blair
2026-03-16 14:07   ` Heikki Krogerus
2026-03-14  1:31 ` [PATCH 2/2] usb: typec: ucsi: add ITE885x I2C transport driver Edward Blair
2026-03-16 14:57   ` Heikki Krogerus
2026-03-16 15:01     ` Edward Blair [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260316150128.30203-1-edward.blair@gmail.com \
    --to=edward.blair@gmail.com \
    --cc=heikki.krogerus@linux.intel.com \
    --cc=linux-usb@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox