[PATCH 2/5] usb: typec: add kernel-doc for priority and mode_selection members

[PATCH 2/5] usb: typec: add kernel-doc for priority and mode_selection members

[Kit Dallege]

Document the priority and mode_selection members of struct
typec_altmode that were added without kernel-doc descriptions.

This fixes the following warnings when building with W=1:

  include/linux/usb/typec_altmode.h: struct member 'priority' not described in 'typec_altmode'
  include/linux/usb/typec_altmode.h: struct member 'mode_selection' not described in 'typec_altmode'

Signed-off-by: Kit Dallege <xaum.io@gmail.com>
Signed-off-by: kovan <xaum.io@gmail.com>
---
 include/linux/usb/typec_altmode.h | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/include/linux/usb/typec_altmode.h b/include/linux/usb/typec_altmode.h
index 0513d333b797..c7cfc4629484 100644
--- a/include/linux/usb/typec_altmode.h
+++ b/include/linux/usb/typec_altmode.h
@@ -26,6 +26,8 @@ struct typec_altmode_ops;
  * @mode: Index of the Mode
  * @vdo: VDO returned by Discover Modes USB PD command
  * @active: Tells has the mode been entered or not
+ * @priority: Numeric priority for alternate mode selection ordering
+ * @mode_selection: Indicates support for the mode selection feature
  * @desc: Optional human readable description of the mode
  * @ops: Operations vector from the driver
  * @cable_ops: Cable operations vector from the driver.
-- 
2.53.0

Re: [PATCH 2/5] usb: typec: add kernel-doc for priority and mode_selection members

[Greg Kroah-Hartman]

On Sun, Mar 15, 2026 at 03:57:41PM +0100, Kit Dallege wrote:
> Document the priority and mode_selection members of struct
> typec_altmode that were added without kernel-doc descriptions.
> 
> This fixes the following warnings when building with W=1:
> 
>   include/linux/usb/typec_altmode.h: struct member 'priority' not described in 'typec_altmode'
>   include/linux/usb/typec_altmode.h: struct member 'mode_selection' not described in 'typec_altmode'
> 
> Signed-off-by: Kit Dallege <xaum.io@gmail.com>
> Signed-off-by: kovan <xaum.io@gmail.com>

Please use your name, not an alias, to sign off on a patch.  And no need
to list it twice.

Also, where are the other 5 patches here?

thanks,

greg k-h

Re: [PATCH 2/5] usb: typec: add kernel-doc for priority and mode_selection members

[Krzysztof Kozlowski]

On 16/03/2026 07:17, Greg Kroah-Hartman wrote:
> On Sun, Mar 15, 2026 at 03:57:41PM +0100, Kit Dallege wrote:
>> Document the priority and mode_selection members of struct
>> typec_altmode that were added without kernel-doc descriptions.
>>
>> This fixes the following warnings when building with W=1:
>>
>>   include/linux/usb/typec_altmode.h: struct member 'priority' not described in 'typec_altmode'
>>   include/linux/usb/typec_altmode.h: struct member 'mode_selection' not described in 'typec_altmode'
>>
>> Signed-off-by: Kit Dallege <xaum.io@gmail.com>
>> Signed-off-by: kovan <xaum.io@gmail.com>
> 
> Please use your name, not an alias, to sign off on a patch.  And no need
> to list it twice.
> 
> Also, where are the other 5 patches here?

FWIW, other postings from this author were called as AI slop, so the
contents should be thoroughly reviewed.

https://lore.kernel.org/all/?q=f%3A%22Kit+Dallege%22

Best regards,
Krzysztof