From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 74B613DA5CF for ; Wed, 18 Mar 2026 14:14:22 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773843262; cv=none; b=Po52tn2Y3KBGm3widUVHOZodqVmQkGucLKOpx+B2NEfFJCyvLvaU97QlQaDpj5BXOnZ5HXu5Kos2GsnOgWbDJMYbEVojEfZ5qIPj4ax7IU144VIWz8M4at3L8xDvL4u2xU9Fzo7Z/1BdM0y4GHS2c2Xg9S8YtVbAw/CWJh07QJc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773843262; c=relaxed/simple; bh=LDPsTmqVOQi/Q3SMosi3u6ribwOvIxr1Z+DXp1t/F64=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=pjGg6zlSaZFRgpzGWr4S1sbrKDYS/F6ZGwXLiibEDabMZ3PcpMYbf3vVvym3Eb7TX+qGGHH41Ssk6MQhBLI7mhTulfgp1gtun5OCvCrGJhxG0J07wbAZWAO2dxbw/PD5xBSaENRhzmQTzvfZ61uoICRhRtjRIwcTW0lD4Rlqwz4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=0mYAUvaj; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="0mYAUvaj" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F634C19421; Wed, 18 Mar 2026 14:14:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773843262; bh=LDPsTmqVOQi/Q3SMosi3u6ribwOvIxr1Z+DXp1t/F64=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=0mYAUvaj7YdVXcNkWxuHmkSWzWwRl3dkQRBI72HYbsMVzPaIZ3nzdkQWL/RiyxsdS x92bgcU/TBj/e+g45V00Zw2GacsN2UZ/w1nikJL2RyVSbtX4m8K61MT9ny2PpNV58z hfqD5rVT33Crpxcywgtesj45c5pJNSMULMu7a2Co= Date: Wed, 18 Mar 2026 15:14:18 +0100 From: Greg KH To: justin.chen@broadcom.com Cc: linux-usb@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, alcooperx@gmail.com, stern@rowland.harvard.edu Subject: Re: [PATCH] usb: ehci-brcm: fix sleep during atomic Message-ID: <2026031801-spinster-scraggly-7504@gregkh> References: <20260312190825.3596757-1-justin.chen@broadcom.net> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260312190825.3596757-1-justin.chen@broadcom.net> On Thu, Mar 12, 2026 at 12:08:25PM -0700, justin.chen@broadcom.com wrote: > From: Justin Chen > > echi_brcm_wait_for_sof() gets called after disabling interrupts > in ehci_brcm_hub_control(). Use the atomic version of poll_timeout > to fix the warning. > > Fixes: ("9df231511bd6 usb: ehci: Add new EHCI driver for Broadcom STB SoC's") > Signed-off-by: Justin Chen > --- > drivers/usb/host/ehci-brcm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ehci-brcm.c b/drivers/usb/host/ehci-brcm.c > index 888e8f6670d2..5e3156f94cc6 100644 > --- a/drivers/usb/host/ehci-brcm.c > +++ b/drivers/usb/host/ehci-brcm.c > @@ -31,8 +31,8 @@ static inline void ehci_brcm_wait_for_sof(struct ehci_hcd *ehci, u32 delay) > int res; > > /* Wait for next microframe (every 125 usecs) */ > - res = readl_relaxed_poll_timeout(&ehci->regs->frame_index, val, > - val != frame_idx, 1, 130); > + res = readl_relaxed_poll_timeout_atomic(&ehci->regs->frame_index, > + val, val != frame_idx, 1, 130); > if (res) > ehci_err(ehci, "Error waiting for SOF\n"); > udelay(delay); > -- > 2.34.1 > > Why is something that has been around for so long just now suddenly being seen? What changed to trigger this? thanks, greg k-h