From: Greg KH <gregkh@linuxfoundation.org>
To: Kit Dallege <xaum.io@gmail.com>
Cc: heikki.krogerus@linux.intel.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] usb: typec: add kernel-doc for priority and mode_selection members
Date: Wed, 18 Mar 2026 16:08:12 +0100 [thread overview]
Message-ID: <2026031803-irregular-overheat-f7e0@gregkh> (raw)
In-Reply-To: <CAAZVx99U8a4w7cZihEyysaKD4R=pgXs4fKEegmvHv0Q3avJg7w@mail.gmail.com>
On Fri, Mar 13, 2026 at 12:29:56PM +0100, Kit Dallege wrote:
> Document the priority and mode_selection members of struct
> typec_altmode that were added without kernel-doc descriptions.
>
> This fixes the following warnings when building with W=1:
>
> include/linux/usb/typec_altmode.h: struct member 'priority' not
> described in 'typec_altmode'
> include/linux/usb/typec_altmode.h: struct member 'mode_selection'
> not described in 'typec_altmode'
>
> Signed-off-by: Kit Dallege <xaum.io@gmail.com>
> ---
> v2: resend so From matches Signed-off-by (Greg KH)
>
> include/linux/usb/typec_altmode.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/linux/usb/typec_altmode.h
> b/include/linux/usb/typec_altmode.h
> index 0513d333b797..c7cfc4629484 100644
> --- a/include/linux/usb/typec_altmode.h
> +++ b/include/linux/usb/typec_altmode.h
> @@ -26,6 +26,8 @@ struct typec_altmode_ops;
> * @mode: Index of the Mode
> * @vdo: VDO returned by Discover Modes USB PD command
> * @active: Tells has the mode been entered or not
> + * @priority: Numeric priority for alternate mode selection ordering
> + * @mode_selection: Indicates support for the mode selection feature
> * @desc: Optional human readable description of the mode
> * @ops: Operations vector from the driver
> * @cable_ops: Cable operations vector from the driver.
> --
> 2.53.0
Sent by someone else before you:
https://lore.kernel.org/r/20260311163320.61534-1-aldocontelk@gmail.com
prev parent reply other threads:[~2026-03-18 15:08 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-13 11:29 [PATCH v2] usb: typec: add kernel-doc for priority and mode_selection members Kit Dallege
2026-03-13 11:39 ` Heikki Krogerus
2026-03-18 15:08 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026031803-irregular-overheat-f7e0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=xaum.io@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox