* [PATCH] thunderbolt: dma_port: kmalloc_array + kzalloc to flex
@ 2026-03-13 21:41 Rosen Penev
2026-03-18 13:38 ` Mika Westerberg
0 siblings, 1 reply; 2+ messages in thread
From: Rosen Penev @ 2026-03-13 21:41 UTC (permalink / raw)
To: linux-usb; +Cc: Andreas Noever, Mika Westerberg, Yehezkel Bernat, open list
Use a single allocation with a flexible array member. Simplifies
allocation and freeing.
Signed-off-by: Rosen Penev <rosenp@gmail.com>
---
drivers/thunderbolt/dma_port.c | 15 +++------------
1 file changed, 3 insertions(+), 12 deletions(-)
diff --git a/drivers/thunderbolt/dma_port.c b/drivers/thunderbolt/dma_port.c
index 334fefe21255..c7c2942fa7be 100644
--- a/drivers/thunderbolt/dma_port.c
+++ b/drivers/thunderbolt/dma_port.c
@@ -55,7 +55,7 @@ struct tb_dma_port {
struct tb_switch *sw;
u8 port;
u32 base;
- u8 *buf;
+ u8 buf[];
};
/*
@@ -209,16 +209,10 @@ struct tb_dma_port *dma_port_alloc(struct tb_switch *sw)
if (port < 0)
return NULL;
- dma = kzalloc_obj(*dma);
+ dma = kzalloc_flex(*dma, buf, MAIL_DATA_DWORDS);
if (!dma)
return NULL;
- dma->buf = kmalloc_array(MAIL_DATA_DWORDS, sizeof(u32), GFP_KERNEL);
- if (!dma->buf) {
- kfree(dma);
- return NULL;
- }
-
dma->sw = sw;
dma->port = port;
dma->base = DMA_PORT_CAP;
@@ -232,10 +226,7 @@ struct tb_dma_port *dma_port_alloc(struct tb_switch *sw)
*/
void dma_port_free(struct tb_dma_port *dma)
{
- if (dma) {
- kfree(dma->buf);
- kfree(dma);
- }
+ kfree(dma);
}
static int dma_port_wait_for_completion(struct tb_dma_port *dma,
--
2.53.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] thunderbolt: dma_port: kmalloc_array + kzalloc to flex
2026-03-13 21:41 [PATCH] thunderbolt: dma_port: kmalloc_array + kzalloc to flex Rosen Penev
@ 2026-03-18 13:38 ` Mika Westerberg
0 siblings, 0 replies; 2+ messages in thread
From: Mika Westerberg @ 2026-03-18 13:38 UTC (permalink / raw)
To: Rosen Penev
Cc: linux-usb, Andreas Noever, Mika Westerberg, Yehezkel Bernat,
open list
On Fri, Mar 13, 2026 at 02:41:37PM -0700, Rosen Penev wrote:
> Use a single allocation with a flexible array member. Simplifies
> allocation and freeing.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
Applied to thunderbolt.git/next, thanks!
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-03-18 13:38 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-13 21:41 [PATCH] thunderbolt: dma_port: kmalloc_array + kzalloc to flex Rosen Penev
2026-03-18 13:38 ` Mika Westerberg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox