From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C5233D8108 for ; Wed, 18 Mar 2026 14:13:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773843235; cv=none; b=Y8QEtBK4abVEDET9pfYtFAiPEqXTnbtlnen5r64Lt6R+/PUDrkSSzAuytkHHL3sR6R+m4KJGDwBaE+S02PpFIgl3zivw7LaC6Ww1qsa1Oov/lPSiUNc9yDYYvADgCO4JoZbKENiYSjHMdZOpESCnVvJKJzMnBS62dSVjmrGiyAQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1773843235; c=relaxed/simple; bh=T3YFrtCmPcyzBYKr/rwj7VCqX3IIGcIdJIqkDUIPdXA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kKY9aJKkPSvd4FyAJlaZ3j/CmtBHOiObRbksnVDSj8G6wQ+7CyFNrWiCiu/LAz2bx8I8GeGQdht2UfIX6HXrqJr5VwmTRWOYkaR+dP8HKufyaN9AkcopBk+InkXZD4yw+5fhHB7Dk8rVxPZlsOHqv3xXlE5ythnY13fkWgfvUsc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=WHkwsmN5; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="WHkwsmN5" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D4EEDC19421; Wed, 18 Mar 2026 14:13:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1773843235; bh=T3YFrtCmPcyzBYKr/rwj7VCqX3IIGcIdJIqkDUIPdXA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=WHkwsmN5uPP1p2dTMy5I82Qr4zWndEyXCAkEExLwV08UCshnJiHY/tiw1wbsl1ayE XMHPBvM9q2ZDnQPUQ77hlJxhuX/Y5Uiy5JqaxukV8XrJYLoAY+NYil0wJwuj1MeZ6s BYG5CAX7OK7VhN3h7sA2UJW5aV9EZVX5WBVyUed0= Date: Wed, 18 Mar 2026 15:13:51 +0100 From: Greg KH To: justin.chen@broadcom.com Cc: linux-usb@vger.kernel.org, bcm-kernel-feedback-list@broadcom.com, alcooperx@gmail.com, stern@rowland.harvard.edu Subject: Re: [PATCH] usb: ehci-brcm: fix sleep during atomic Message-ID: <2026031819-awoke-overdrawn-4287@gregkh> References: <20260312190825.3596757-1-justin.chen@broadcom.net> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260312190825.3596757-1-justin.chen@broadcom.net> On Thu, Mar 12, 2026 at 12:08:25PM -0700, justin.chen@broadcom.com wrote: > From: Justin Chen > > echi_brcm_wait_for_sof() gets called after disabling interrupts > in ehci_brcm_hub_control(). Use the atomic version of poll_timeout > to fix the warning. > > Fixes: ("9df231511bd6 usb: ehci: Add new EHCI driver for Broadcom STB SoC's") Can you resend this with the proper format for how Fixes: lines should be? It's in the documentation, otherwise our scripts will reject this. thanks, greg k-h