Caldigit TS5+ problem with work in progress patch

Caldigit TS5+ problem with work in progress patch

[François Scala]

Hello,


Last year, I purchased the TS5plus docker station from Caldigit 
(https://www.caldigit.com/thunderbolt-5-dock-ts5-plus/)

It is a particular docking station as it has two USB controllers.

This cause a problem with the Linux kernel, where the typec_probe 
function is designed to handle only one.

    Mar 09 09:13:54 alpha26 kernel: sysfs: cannot create duplicate
    filename '/devices/platform/USBC000:00/typec/port1/port1.0/partner'
    Mar 09 09:13:54 alpha26 kernel: CPU: 8 UID: 0 PID: 14 Comm:
    kworker/u64:1 Tainted: G           OE       6.19.6-arch1-1 #1
    PREEMPT(full)  a70f585a3574c37bff18875a6cf7bd8652b4cbca
    Mar 09 09:13:54 alpha26 kernel: Tainted: [O]=OOT_MODULE,
    [E]=UNSIGNED_MODULE
    Mar 09 09:13:54 alpha26 kernel: Hardware name: Dell Inc. Dell Pro
    Max 14 Premium MA14250/0TMRG5, BIOS 1.7.1 12/11/2025
    Mar 09 09:13:54 alpha26 kernel: Workqueue: USBC000:00-con2
    ucsi_poll_worker [typec_ucsi]

    Mar 09 09:13:54 alpha26 kernel: Call Trace:
    Mar 09 09:13:54 alpha26 kernel:  <TASK>
    Mar 09 09:13:54 alpha26 kernel:  dump_stack_lvl+0x5d/0x80
    Mar 09 09:13:54 alpha26 kernel:  sysfs_warn_dup.cold+0x17/0x23
    Mar 09 09:13:54 alpha26 kernel: sysfs_do_create_link_sd+0xc6/0xd0
    Mar 09 09:13:54 alpha26 kernel:  typec_probe+0x75/0xf0 [typec
    9ceda448c6e572f91f8deb4f238aee9fc6b9153b]
    Mar 09 09:13:54 alpha26 kernel:  really_probe+0xde/0x380
    ...

So I started to work on a patch to handle this situation (available for 
kernel 6.19 here: 
https://gitlab.archlinux.org/fs75/linux-ts5plus/-/blob/v6.19-ts5plus-test/ts5-test.patch?ref_type=heads 
)

Instead of using the hard coded "partner" name, it now use the device 
name instead. And the struct is updated to have multiple partners.

    $ ls -la /sys/devices/platform/USBC000:00/typec/port1/port1.0
    drwxr-xr-x 4 root root    0 Mar 22 17:17 .
    drwxr-xr-x 9 root root    0 Mar 22 17:16 ..
    -rw-r--r-- 1 root root 4096 Mar 22 17:17 active
    -r--r--r-- 1 root root 4096 Mar 22 17:17 mode
    drwxr-xr-x 2 root root    0 Mar 22 17:16 mode1
    lrwxrwxrwx 1 root root    0 Mar 22 17:17 port1-partner.0 ->
    ../port1-partner/port1-partner.0
    lrwxrwxrwx 1 root root    0 Mar 22 17:17 port1-partner.1 ->
    ../port1-partner/port1-partner.1
    drwxr-xr-x 2 root root    0 Mar 22 17:16 power
    -r--r--r-- 1 root root 4096 Mar 22 17:17 svid
    -rw-r--r-- 1 root root 4096 Mar 22 17:16 uevent
    -r--r--r-- 1 root root 4096 Mar 22 17:17 vdo

My question is: how do I get my patch reviewed/merged ?


Thank you

François

Re: Caldigit TS5+ problem with work in progress patch

[Greg KH]

On Sun, Mar 22, 2026 at 05:37:11PM +0100, François Scala wrote:
> So I started to work on a patch to handle this situation (available for
> kernel 6.19 here: https://gitlab.archlinux.org/fs75/linux-ts5plus/-/blob/v6.19-ts5plus-test/ts5-test.patch?ref_type=heads

Great!

> My question is: how do I get my patch reviewed/merged ?

Did you read Documentation/process/submitting-patches.rst ?  That's the
place to start.  You might want to start by running
scripts/checkpatch.pl on your changes, I see a bunch of minor coding
style issues that you can easily fix up.

thanks,

greg k-h

Re: Caldigit TS5+ problem with work in progress patch

[François Scala]

Hi Greg,

I've rebased my patch on the latest kernel version 7.0-rc5 and fixed the 
linting 
errors: https://gitlab.archlinux.org/fs75/linux-ts5plus/-/blob/v7.0-ts5plus-test/ts5-test.patch?ref_type=heads
The change log of the patch:

usb: typec: Allow altmode to have multiple partners

Signed-off-by: François Scala <francois@scala.name>

Now, how can this been reviewed/tested ?

Thanks
François

On 22/03/2026 20.45, Greg KH wrote:
> On Sun, Mar 22, 2026 at 05:37:11PM +0100, François Scala wrote:
>> My question is: how do I get my patch reviewed/merged ?
> Did you read Documentation/process/submitting-patches.rst ?  That's the
> place to start.  You might want to start by running
> scripts/checkpatch.pl on your changes, I see a bunch of minor coding
> style issues that you can easily fix up.
>
> thanks,
>
> greg k-h
>

Re: Caldigit TS5+ problem with work in progress patch

[Greg KH]

On Tue, Mar 24, 2026 at 11:00:15AM +0100, François Scala wrote:
> Hi Greg,
> 
> I've rebased my patch on the latest kernel version 7.0-rc5 and fixed the
> linting errors: https://gitlab.archlinux.org/fs75/linux-ts5plus/-/blob/v7.0-ts5plus-test/ts5-test.patch?ref_type=heads
> The change log of the patch:
> 
> usb: typec: Allow altmode to have multiple partners
> 
> Signed-off-by: François Scala <francois@scala.name>
> 
> Now, how can this been reviewed/tested ?

Again, read the document I pointed you at, you need to submit this as a
patch like any of the other thousands of patches that get submitted each
day :)

That document should guide you through the process, if you have any
specific questions about it, please let us know

thanks,

greg k-h