Re: [PATCH] USB: serial: pl2303: add new PID to support PL256X (TYPE_MP)

[kernel test robot <lkp@intel.com>]

Hi Charles,

kernel test robot noticed the following build warnings:

[auto build test WARNING on johan-usb-serial/usb-next]
[also build test WARNING on johan-usb-serial/usb-linus usb/usb-testing usb/usb-next usb/usb-linus tty/tty-testing tty/tty-next tty/tty-linus next-20260324]
[cannot apply to linus/master v6.16-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Charles-Yeh/USB-serial-pl2303-add-new-PID-to-support-PL256X-TYPE_MP/20260324-235444
base:   https://git.kernel.org/pub/scm/linux/kernel/git/johan/usb-serial.git usb-next
patch link:    https://lore.kernel.org/r/20260324124619.843-1-charlesyeh522%40gmail.com
patch subject: [PATCH] USB: serial: pl2303: add new PID to support PL256X (TYPE_MP)
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20260324/202603242312.CO0aTujP-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260324/202603242312.CO0aTujP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202603242312.CO0aTujP-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/usb/serial/pl2303.c: In function 'pl2303_update_reg':
>> drivers/usb/serial/pl2303.c:350:24: warning: unused variable 'dev' [-Wunused-variable]
     350 |         struct device *dev = &serial->interface->dev;
         |                        ^~~


vim +/dev +350 drivers/usb/serial/pl2303.c

   346	
   347	static int pl2303_update_reg(struct usb_serial *serial, u8 reg, u8 mask, u8 val)
   348	{
   349		struct pl2303_serial_private *spriv = usb_get_serial_data(serial);
 > 350		struct device *dev = &serial->interface->dev;
   351		int ret = 0;
   352		u8 *buf;
   353	
   354		buf = kmalloc(1, GFP_KERNEL);
   355		if (!buf)
   356			return -ENOMEM;
   357	
   358		if (spriv->type == &pl2303_type_data[TYPE_HXN] ||
   359			spriv->type == &pl2303_type_data[TYPE_MP]) {
   360			ret = pl2303_vendor_read(serial, reg, buf);
   361		} else {
   362			ret = pl2303_vendor_read(serial, reg | 0x80, buf);
   363		}
   364	
   365		if (ret)
   366			goto out_free;
   367	
   368		*buf &= ~mask;
   369		*buf |= val & mask;
   370	
   371		ret = pl2303_vendor_write(serial, reg, *buf);
   372	out_free:
   373		kfree(buf);
   374	
   375		return ret;
   376	}
   377	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki