public inbox for linux-usb@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Pecio <michal.pecio@gmail.com>
To: Mathias Nyman <mathias.nyman@linux.intel.com>
Cc: Mathias Nyman <mathias.nyman@intel.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Xu Rao <raoxu@uniontech.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: xhci: Fix debugfs bandwidth reporting
Date: Wed, 25 Mar 2026 11:32:46 +0100	[thread overview]
Message-ID: <20260325113246.07681667.michal.pecio@gmail.com> (raw)
In-Reply-To: <d9ae5a8b-3aa0-451e-8a42-80ef73e2d210@linux.intel.com>

On Thu, 19 Mar 2026 23:04:38 +0200, Mathias Nyman wrote:
> On 3/4/26 12:49, Michal Pecio wrote:
> > Replace kernel USB speed numbers with xHCI protocol IDs expected by HW.
> > They are numerically equal up to high speed, but instead of SuperSpeed
> > we were querying SuperSpeed+.
> > 
> > Gen1 hardware rejects such commands with TRB Error, which resulted in
> > zero available bandwidth being shown.
> > 
> > While at that, report command failure as IO error, not zero bandwidth.
> > 
> > Signed-off-by: Michal Pecio <michal.pecio@gmail.com>  
> 
> Added to queue

Hi,

Thanks for taking the patch, but can we have a last minute swap for
a v2 or optionally v3?

Problem is that returning -EIO is common (the command is optional)
and it upsets userspace: "grep -r" spams the console with errors,
"zip -R" terminates and doesn't include remaining files, etc.
So I would prefer to print an error string in this case.
"Real" errors will still be returned ordinarily.

The optional v3 also renames the new directory for consistency.
Technically it's a breaking change, but I believe it's permissible
in debugfs, particularly for an interface only added recently.

Regards,
Michal

  reply	other threads:[~2026-03-25 10:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-03-04 10:49 [PATCH] usb: xhci: Fix debugfs bandwidth reporting Michal Pecio
2026-03-19 21:04 ` Mathias Nyman
2026-03-25 10:32   ` Michal Pecio [this message]
2026-03-25 10:33     ` [PATCH v2] " Michal Pecio
2026-03-25 10:34     ` [PATCH v3] " Michal Pecio
2026-03-25 12:24     ` [PATCH] " Mathias Nyman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260325113246.07681667.michal.pecio@gmail.com \
    --to=michal.pecio@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=mathias.nyman@intel.com \
    --cc=mathias.nyman@linux.intel.com \
    --cc=raoxu@uniontech.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox