* [PATCH 2/2] USB: serial: pl2303: add new PID to support PL256X (TYPE_MP)
@ 2026-03-25 12:01 Charles Yeh
2026-03-25 13:37 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Charles Yeh @ 2026-03-25 12:01 UTC (permalink / raw)
To: gregkh, johan, linux-usb; +Cc: charles-yeh, Charles Yeh, kernel test robot
Add support for the PL256X (TYPE_MP) device by adding its PID.
Also fix an unused variable warning in pl2303_update_reg() reported
by the kernel test robot.
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202603250523.9ktgw2Ju-lkp@intel.com/
Signed-off-by: Charles Yeh <charlesyeh522@gmail.com>
---
v2:
- Remove unused 'struct device *dev' variable in pl2303_update_reg()
to fix build warning.
---
drivers/usb/serial/pl2303.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
index e5bbda1d63b3..67b78d2fcc92 100644
--- a/drivers/usb/serial/pl2303.c
+++ b/drivers/usb/serial/pl2303.c
@@ -347,7 +347,6 @@ static int pl2303_vendor_write(struct usb_serial *serial, u16 value, u16 index)
static int pl2303_update_reg(struct usb_serial *serial, u8 reg, u8 mask, u8 val)
{
struct pl2303_serial_private *spriv = usb_get_serial_data(serial);
- struct device *dev = &serial->interface->dev;
int ret = 0;
u8 *buf;
--
2.51.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] USB: serial: pl2303: add new PID to support PL256X (TYPE_MP)
2026-03-25 12:01 [PATCH 2/2] USB: serial: pl2303: add new PID to support PL256X (TYPE_MP) Charles Yeh
@ 2026-03-25 13:37 ` Greg KH
2026-03-27 2:29 ` Charles Yeh
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2026-03-25 13:37 UTC (permalink / raw)
To: Charles Yeh; +Cc: johan, linux-usb, charles-yeh, kernel test robot
On Wed, Mar 25, 2026 at 08:01:23PM +0800, Charles Yeh wrote:
> Add support for the PL256X (TYPE_MP) device by adding its PID.
> Also fix an unused variable warning in pl2303_update_reg() reported
> by the kernel test robot.
>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202603250523.9ktgw2Ju-lkp@intel.com/
> Signed-off-by: Charles Yeh <charlesyeh522@gmail.com>
> ---
> v2:
> - Remove unused 'struct device *dev' variable in pl2303_update_reg()
> to fix build warning.
> ---
> drivers/usb/serial/pl2303.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/usb/serial/pl2303.c b/drivers/usb/serial/pl2303.c
> index e5bbda1d63b3..67b78d2fcc92 100644
> --- a/drivers/usb/serial/pl2303.c
> +++ b/drivers/usb/serial/pl2303.c
> @@ -347,7 +347,6 @@ static int pl2303_vendor_write(struct usb_serial *serial, u16 value, u16 index)
> static int pl2303_update_reg(struct usb_serial *serial, u8 reg, u8 mask, u8 val)
> {
> struct pl2303_serial_private *spriv = usb_get_serial_data(serial);
> - struct device *dev = &serial->interface->dev;
> int ret = 0;
> u8 *buf;
>
> --
> 2.51.0
>
Please don't add a bug and then fix it up in a later patch, just redo
the original patch and send it as a v2 as the documentation describes
how to do.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 2/2] USB: serial: pl2303: add new PID to support PL256X (TYPE_MP)
2026-03-25 13:37 ` Greg KH
@ 2026-03-27 2:29 ` Charles Yeh
0 siblings, 0 replies; 3+ messages in thread
From: Charles Yeh @ 2026-03-27 2:29 UTC (permalink / raw)
To: Greg KH; +Cc: johan, linux-usb, charles-yeh, kernel test robot
> just redo the original patch and send it as a v2 as the documentation describes
> how to do.
Thanks for the guidance.
I have updated the original patch and submitted it as v2 as requested.
Thanks,
Charles.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-03-27 2:29 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-03-25 12:01 [PATCH 2/2] USB: serial: pl2303: add new PID to support PL256X (TYPE_MP) Charles Yeh
2026-03-25 13:37 ` Greg KH
2026-03-27 2:29 ` Charles Yeh
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox