From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "yongchao.wu" <yongchao.wu@autochips.com>
Cc: Peter Chen <peter.chen@kernel.org>,
Pawel Laszczak <pawell@cadence.com>,
Roger Quadros <rogerq@kernel.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: cdns3: gadget: fix NULL pointer dereference in ep_queue
Date: Sat, 28 Mar 2026 17:03:14 +0100 [thread overview]
Message-ID: <2026032859-gave-smokeless-a5f4@gregkh> (raw)
In-Reply-To: <20260328143842.57315-1-yongchao.wu@autochips.com>
On Sat, Mar 28, 2026 at 10:38:42PM +0800, yongchao.wu wrote:
> When the gadget endpoint is disabled or not yet configured, the ep->desc
> pointer can be NULL. This leads to a NULL pointer dereference when
> __cdns3_gadget_ep_queue() is called, causing a kernel crash.
>
> Add a check to return -ESHUTDOWN if ep->desc is NULL, which is the
> standard return code for unconfigured endpoints.
>
> This prevents potential crashes when ep_queue is called on endpoints
> that are not ready.
>
> Signed-off-by: yongchao.wu <yongchao.wu@autochips.com>
Please use your name, not your email alias, for the From: and
signed-off-by lines.
thanks,
greg k-h
next prev parent reply other threads:[~2026-03-28 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-28 14:38 [PATCH] usb: cdns3: gadget: fix NULL pointer dereference in ep_queue yongchao.wu
2026-03-28 16:03 ` Greg Kroah-Hartman [this message]
2026-03-29 1:34 ` Yongchao Wu
2026-03-30 9:21 ` Peter Chen (CIX)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026032859-gave-smokeless-a5f4@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=pawell@cadence.com \
--cc=peter.chen@kernel.org \
--cc=rogerq@kernel.org \
--cc=yongchao.wu@autochips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox