Re: [PATCH] usb: common: fix all alignment warnings in usb-otg-fsm.c

[Greg KH <gregkh@linuxfoundation.org>]

On Sat, Mar 28, 2026 at 05:33:03PM +0000, Stanisław Maciej Molsa wrote:
> Hi Peter,
> 
> This is my first small contribution to the USB subsystem.

No need for this here.

> 
> Fixed all "Alignment should match open parenthesis" warnings in
> usb-otg-fsm.c, as
> reported by checkpatch.pl
> 
> Signed-off-by: Stanisław Maciej Molsa <stanislawmolsa@gmail.com>
> ---
>  drivers/usb/common/usb-otg-fsm.c | 42 ++++++++++++++++----------------
>  1 file changed, 21 insertions(+), 21 deletions(-)
> 
> diff --git a/drivers/usb/common/usb-otg-fsm.c b/drivers/usb/common/usb-otg-fsm.c
> index e11803225775..5dcaa6c2057f 100644
> --- a/drivers/usb/common/usb-otg-fsm.c
> +++ b/drivers/usb/common/usb-otg-fsm.c
> @@ -32,7 +32,7 @@ static int otg_set_protocol(struct otg_fsm *fsm, int protocol)
>  
>  	if (fsm->protocol != protocol) {
>  		VDBG("Changing role fsm->protocol= %d; new protocol= %d\n",
> -			fsm->protocol, protocol);
> +		     fsm->protocol, protocol);

Please do not do coding style changes EXCEPT in subsystems that
specifically ask for them to be done in (like drivers/staging/),
otherwise there will be nothing but constant churn in the kernel tree.

thanks,

greg k-h