Re: [RFC PATCH 1/2] xhci: prevent automatic endpoint restart after stall or error

Thinh Nguyen
2026-04-01T22:09:10Z

On Mon, Mar 30, 2026, Mathias Nyman wrote:
>
> >
> > On a separate note, will you plan to implement the clear-halt for EPROTO
> > in xhci?
>
> I don't think this should be part of xhci driver. Decision to send control requests
> to the device should be done by core or class drivers.
>

This not like STALL where it's standardized for the core or class driver
to know how to handle. The programming sequence for the errors that
resulted in EPROTO from xhci is specific to xhci. That is, the xhci
reset endpoint command will reset the bulk sequence, it's specific to
xhci. The xhci spec recommends to send a clear-halt for this scenario,
not the USB spec or any other class specific spec. So we should not
delegate this to the core or class driver to handle.

BR,
Thinh