From: Nathan Rebello <nathan.c.rebello@gmail.com>
To: gregkh@linuxfoundation.org, tiwai@suse.de
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
heikki.krogerus@linux.intel.com,
Nathan Rebello <nathan.c.rebello@gmail.com>
Subject: Re: Spurious errors "ucsi_acpi USBC000:00: bogus connector number in CCI: 1" on 7.0-rc7
Date: Tue, 7 Apr 2026 02:21:13 -0400 [thread overview]
Message-ID: <20260407062113.1494-1-nathan.c.rebello@gmail.com> (raw)
In-Reply-To: <2026040734-headfirst-tingly-e6ea@gregkh>
On Tue, Apr 07, 2026 at 07:58:00AM +0200, Greg Kroah-Hartman wrote:
> On Tue, Apr 07, 2026 at 07:38:50AM +0200, Takashi Iwai wrote:
> > Is this a firmware bug, or some missing piece in the code?
> > Judging from the message, it means that ucsi->cap.num_connectors is 0,
> > I suppose.
>
> Ugh, what's the odds this is an off-by-one error in the firmware? :)
>
> Nathan and Heikki, any ideas?
This isn't an off-by-one or firmware bug. Takashi is right that
num_connectors is 0. The validation checks against
ucsi->cap.num_connectors, but notifications can arrive before
ucsi_init() has populated that field via GET_CAPABILITY.
Pre-init notifications are already handled safely by the early-event
guard in ucsi_connector_change(), so the fix is to skip validation
when num_connectors hasn't been initialized yet.
Sending a fix shortly.
Thanks,
Nathan
prev parent reply other threads:[~2026-04-07 6:21 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-07 5:38 Spurious errors "ucsi_acpi USBC000:00: bogus connector number in CCI: 1" on 7.0-rc7 Takashi Iwai
2026-04-07 5:58 ` Greg Kroah-Hartman
2026-04-07 6:21 ` Nathan Rebello [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260407062113.1494-1-nathan.c.rebello@gmail.com \
--to=nathan.c.rebello@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heikki.krogerus@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox