From: Greg KH <gregkh@linuxfoundation.org>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: peter.chen@kernel.org, jun.li@nxp.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org, imx@lists.linux.dev
Subject: Re: [PATCH v2 3/3] usb: chipidea: core: convert ci_role_switch to local variable
Date: Sun, 26 Apr 2026 22:29:44 +0200 [thread overview]
Message-ID: <2026042606-plaything-elusive-592f@gregkh> (raw)
In-Reply-To: <20260423102002.2675414-3-xu.yang_2@nxp.com>
On Thu, Apr 23, 2026 at 06:20:02PM +0800, Xu Yang wrote:
> When a system contains multiple USB controllers, the global ci_role_switch
> variable may be overwritten by subsequent driver initialization code.
>
> This can cause issues in the following cases:
> - The 2nd ci_hdrc_probe() sees ci_role_switch.fwnode as non-NULL even
> though the "usb-role-switch" property is not present for the controller.
> - When the ci_hdrc device is unbound and bound again, ci_role_switch
> fwnode will not be reassigned, and the old value will be used instead.
>
> Convert ci_role_switch to a local variable to fix these issues.
>
> Fixes: 05559f10ed79 ("usb: chipidea: add role switch class support")
> Cc: stable@vger.kernel.org
> Acked-by: Peter Chen <peter.chen@kernel.org>
> Reviewed-by: Frank Li <Frank.Li@nxp.com>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
You can not have patch 3 out of 3 be only for stable kernels. Please
break this up into 2 different patch series, one for bugfixes to go to
7.1-final, and the other for new stuff for 7.2-rc1.
thanks,
greg k-h
next prev parent reply other threads:[~2026-04-27 3:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-23 10:20 [PATCH v2 1/3] usb: chipidea: udc: add a helper ci_udc_enable_vbus_irq() Xu Yang
2026-04-23 10:20 ` [PATCH v2 2/3] usb: chipidea: udc: support dynamic gadget add/remove Xu Yang
2026-04-23 10:20 ` [PATCH v2 3/3] usb: chipidea: core: convert ci_role_switch to local variable Xu Yang
2026-04-26 20:29 ` Greg KH [this message]
2026-04-27 7:43 ` Xu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026042606-plaything-elusive-592f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=imx@lists.linux.dev \
--cc=jun.li@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter.chen@kernel.org \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox