From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f47.google.com (mail-pj1-f47.google.com [209.85.216.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 263E3401A26 for ; Wed, 6 May 2026 15:27:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778081233; cv=none; b=QadLOputne5jR99LepIjCKzmb+AUf+obJxs6yHUWo6sKClsorxM9HxG3+6qOT/G3FgDWqCgk3uNyDwCNdL97H+lcRhePmPDfLIRi9VHBYA1NEkHn9A4GgSLlSYaZcFwWiiHaCWysmY8jPmnb4hIqqIqS2ysA0drO9+LC69hjBSU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778081233; c=relaxed/simple; bh=SkBOX6fDWuILt3NDIue2RThsK+F/RfZ0aMZvoLyOuwU=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=V5neseK9WlOhwJ0LyPmyGXGWttH9Sxt8rAHQkKDVyTangx6L4SHi/QtKT6WrTMi/YQVo2eE9DXPybsM4VoEWiYmxLxmq6NGzXADSVXP+DcipGFTmJsfmQnaroG9G/1lSmHzgiPKXY88GXEArzBvNsDqJvPjSde0Zl+q6t4Qgk4c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=UfeYdcQX; arc=none smtp.client-ip=209.85.216.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="UfeYdcQX" Received: by mail-pj1-f47.google.com with SMTP id 98e67ed59e1d1-36534668247so3879957a91.1 for ; Wed, 06 May 2026 08:27:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778081232; x=1778686032; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ZC6Xht6xACWuhXxwl0DvhLfosR4WdiVXz/heDFGTozk=; b=UfeYdcQXldx8Jbc3SVMOcnl1Q4v4/tLKcsmlYXHXP6AtsFOeKZP+kweeSo904BC64I 7jMoj9DC0HbddB7dH/tOmoLBr2VIfmCUxgB+Jopo08SKxCa68//XPhlgoTNdc044pq5p FGAR8nOidpMHWS9G7I7x7eOrL1fgUA/SNoKyLcBbe/u+zEaZ7/ShCJKO6pNHncoU+SQ8 GmF6g6dH+bcmY5oE1VVB23AJLgwVtA8+AGtIH0l9toESPvS5oyAGxcWdwR0fiRA6Zb1P Ejqdb1n0qRuF1snk8f8BGnUMwtXBr4hZbLjHk4pjfWZ9oQlPoqsXrjYMkWLS9cYHQwNs +yxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778081232; x=1778686032; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ZC6Xht6xACWuhXxwl0DvhLfosR4WdiVXz/heDFGTozk=; b=cUcB2zuDGkiA3QvF9m4yC/b5vmgQZotSCcjL4n/yOK/vGYETR6f/DSHeb89PYHEF80 FXaXsWFXmJrzumE8x8tMyYmecE10Kr4AljHFfu4IKjqaw2F/ERngITPq6Q2w+1szsdhH vqgepS6t33wXdS6o8agHR2ebczvzOgECkurjNqXAWS9/rZvsqRbKMj4UPCaJ4WUxiy9W G18d0ArdU4kkSCZbIxJrGuwJQPobA+uDibPmmxa1HRsdSow2HS5R5kFrxj+NSmXPgQV6 A6KCGxCcTUXL3sKUl6f8xRh0ka+U05f+uc+M1dhF68u5iXgCypeeE5RCI9pszPE2W2Zd E8Ww== X-Forwarded-Encrypted: i=1; AFNElJ9R6OechRtLf69g8XRwfM5170gSIKD+gcrqt5JW0eHjytbcoRmFePRsxURMJ7jAEHBs+c9Nh7BPlUk=@vger.kernel.org X-Gm-Message-State: AOJu0YyFFlTaXGxsK22VkTzqGmIJj+wx+n62GdAy3XHwycXSVYd9rhiZ gRBHIhsWFWzOpKgg6y1cd6/wTWtfwdQDA0S5/8JFkqOBUVAh2vLXWiC8 X-Gm-Gg: AeBDietAkABCiio1IE+wesm0ifakX/tsCHafzCshtRzkNJQciR8zhI+oXWER1R+IoH4 QxeQuJnsN2IcgBrMEGJiXRFJBkh6EjZJwLTqBF8qt/VdXgwAJM0uiaGFsucVIB40iXiRMROzaIm XlQjuvvl4dsh+XIMU/nd4gBH1MWUQHklR4IHEFE11CFGeuolIm/o2DDcVcFhKTH8SxBf3qUSG/2 g3WZS/QvhJtTJZAHrC5TBMdLUuDg1pPj7O3KLwM6rsCVjQ9UDS3heQU2wCHhAg9YTc284AywgCA zP5sRjE6F1tvW3uLzBjfNVFGOVAYycGF2EVuXvT80ddKr54s6IJAyJ4Fl9rXSPd+36sUP1WM9l/ 69txRSJYAfVqlerCvjVZiu87bpGCtLdBxC7M9Z5IsIpmZMpCAss91Uto9XQ6efTvpNVPnazxyz1 I689GY5WWiic2Y9Uh9LHp4lEpy9yOsYrtVeT9NaHScjO564EPKxv8= X-Received: by 2002:a17:90b:4b87:b0:35c:1f29:712f with SMTP id 98e67ed59e1d1-365ac76bae1mr3949539a91.24.1778081231591; Wed, 06 May 2026 08:27:11 -0700 (PDT) Received: from localhost.localdomain ([106.0.57.242]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-c8242ab8bf4sm2484894a12.4.2026.05.06.08.27.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 06 May 2026 08:27:10 -0700 (PDT) From: Sajal Gupta To: petkan@nucleusys.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sajal Gupta Subject: [PATCH net-next] net: usb: pegasus: replace simple_strtoul with kstrtouint Date: Wed, 6 May 2026 20:56:36 +0530 Message-ID: <20260506152653.52329-1-sajal2005gupta@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit simple_strtoul() is deprecated as it has no error checking. Replace it with kstrtouint() which returns an error code on invalid input, and add appropriate error handling. Also add a NULL check before parsing flags, since strsep() can set id to NULL if the input has fewer tokens than expected. Signed-off-by: Sajal Gupta --- drivers/net/usb/pegasus.c | 26 ++++++++++++++++++++------ 1 file changed, 20 insertions(+), 6 deletions(-) diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c index db85f40734d7..d45f08f8f22e 100644 --- a/drivers/net/usb/pegasus.c +++ b/drivers/net/usb/pegasus.c @@ -1327,15 +1327,29 @@ static void __init parse_id(char *id) { unsigned int vendor_id = 0, device_id = 0, flags = 0, i = 0; char *token, *name = NULL; + int err; - if ((token = strsep(&id, ":")) != NULL) + token = strsep(&id, ":"); + if (token) name = token; /* name now points to a null terminated string*/ - if ((token = strsep(&id, ":")) != NULL) - vendor_id = simple_strtoul(token, NULL, 16); - if ((token = strsep(&id, ":")) != NULL) - device_id = simple_strtoul(token, NULL, 16); - flags = simple_strtoul(id, NULL, 16); + token = strsep(&id, ":"); + if (token) { + err = kstrtouint(token, 16, &vendor_id); + if (err) + return; + } + token = strsep(&id, ":"); + if (token) { + err = kstrtouint(token, 16, &device_id); + if (err) + return; + } + if (id) { + err = kstrtouint(id, 16, &flags); + if (err) + return; + } pr_info("%s: new device %s, vendor ID 0x%04x, device ID 0x%04x, flags: 0x%x\n", driver_name, name, vendor_id, device_id, flags); -- 2.54.0