From: Jakub Kicinski <kuba@kernel.org>
To: Sajal Gupta <sajal2005gupta@gmail.com>
Cc: petkan@nucleusys.com, andrew+netdev@lunn.ch, davem@davemloft.net,
edumazet@google.com, pabeni@redhat.com,
linux-usb@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next] net: usb: pegasus: replace simple_strtoul with kstrtouint
Date: Fri, 8 May 2026 18:17:41 -0700 [thread overview]
Message-ID: <20260508181741.50c093ee@kernel.org> (raw)
In-Reply-To: <20260506152653.52329-1-sajal2005gupta@gmail.com>
On Wed, 6 May 2026 20:56:36 +0530 Sajal Gupta wrote:
> + token = strsep(&id, ":");
> + if (token) {
> + err = kstrtouint(token, 16, &vendor_id);
> + if (err)
> + return;
> + }
Why bother capturing err if we can't return it?
if (token && kstrtouint(token, 16, &vendor_id))
prev parent reply other threads:[~2026-05-09 1:17 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 15:26 [PATCH net-next] net: usb: pegasus: replace simple_strtoul with kstrtouint Sajal Gupta
2026-05-09 1:17 ` Jakub Kicinski
2026-05-09 1:17 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508181741.50c093ee@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petkan@nucleusys.com \
--cc=sajal2005gupta@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox