From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f178.google.com (mail-pg1-f178.google.com [209.85.215.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 573E138759C for ; Sat, 9 May 2026 09:56:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778320569; cv=none; b=MraMdUPSDKcAQr3rYfEkpLomjVyLjVUAk3GcV79hDVKEwsWlpvRcsrfWvypZGK5BVE+PxR/e8JT97xn2AyrB01zjmgg7mSJ8W7vC4GQ6jFz8nMywxx9b0lCx+PxYPWf1ASJwG4x+8hPaF3lKb3pP73hF7v+ys+AA2tUOU4n9EQI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778320569; c=relaxed/simple; bh=BKQpBYpbdlRPMoavHmhYs8byFtP2vgGBQl3nAxIAiiA=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=BogiJFtyT7DDafwgLqn1yg1NtSEVslRm3XzRPpntCt2LSfHuSm3RfexKJl6Yi+iwzW3wd2NePT8RwkbTvKjVKFZVgoKhoqvU7L8sHwUwxnr8vgK12QzjbY1bu4a7LPEq/WNJJtPwoSFmmeY30CmY+iPVi2voZz8JA2IJ7OTx0gw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T8nWp/jX; arc=none smtp.client-ip=209.85.215.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T8nWp/jX" Received: by mail-pg1-f178.google.com with SMTP id 41be03b00d2f7-c801912c903so1211307a12.0 for ; Sat, 09 May 2026 02:56:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778320568; x=1778925368; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=5F59HTLBnwz0/GR5Td1Do25Vw59YKJu/Lja+nEVeSFQ=; b=T8nWp/jXbQ+AGx84znhw7YiIDwhGcwWwUfk/P7r5QTcYEYOEWAG3oSTDO1EhdnHX4N OkCgz8qAkz/905ud9lb+jjPtbByqbIV6Azna5LdBkMNg0ygGAy8kYly1kp5H8UJHPdsN ddzXHNliuCKmPd3grcmqImyuWqhqxzUxkQCHA8RpHl7J4rZnKxfmlYVNbHWqdWC5EEvz hSBEiZqJsovyP4+LyFK43hCdiMAWHAR5O8TuiwbyRIV55+y8+rH7AliTXdsMcvEMez4n HtdjJW90qVARTHUKneps6iljKxx6lDVzMLuwrZ8dCETcPOt5yRhxzpVb1dooLI8wnWyT YDyA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778320568; x=1778925368; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=5F59HTLBnwz0/GR5Td1Do25Vw59YKJu/Lja+nEVeSFQ=; b=MTelozs5wpaftTNZB5LnT+e5BfQ8JHQBoUO3Rb/RlontDXWxdYXNiAyeU7KdZOK/wI tFVW33IJvIxrEsma4e5gxu4mLJKUEcHWmHaguLAls0XkUjisLzw9d1Kq+5H/EzoggiLy fQz9Q44C50TCa/5muGBdkyKO/wz9SH9q0jOLM3L5ozuNZaaP1Cal3FAaaM+oddTw9Vu0 sN3EhGVcFgHTKHuj+tBBIe8uapmkzzXyO9Eq51ILNHOlHmAhNn5cmsiUA/gEWhoUmPm1 xKzHEwDoQNbvCTw6QPRl/tcfUxSfCXyBPm+mw4Dek3f4+umltdLtg5QUGnimVKS3wwnN QjXw== X-Forwarded-Encrypted: i=1; AFNElJ9xDroRhSi6ss7Bbyc9VU4whu2V0iBBcvv+RXbfbN2+wnVg28QB7FSL6KvtpvLxmjbRYg4W1/8y+jY=@vger.kernel.org X-Gm-Message-State: AOJu0Yw9hqUCwkTf+tslxo34zpVgnzxNwI16ss1DjDMks/5pg+tGCGaI tVExQjFgtVoi/ittEdfZjzz49dN6/Bb9fBrG7bCdK1L7+e5vchj0t3/0 X-Gm-Gg: Acq92OF6qu2gqnE0+/KUBDNgLf0u19vObWOvfIHLwngxIWwsW2RCJ72OZMtXj93OzkM OFVlMlBIpqZ3rXpgEcPKUxPymORXelTdnEi91NYCDfm26Gz7fVpcp4+91DemaRNQ1KSK1hVkdy/ jTQ10fHCrxYwvBK01xdd9Oscppb30O3jmhLrOOocoOJRYUkrDjXj8kLFQOGVv4QPb/UtQFlHmx2 3pALYdBdK7glfYyV2P2t+N7Hc22P+nl41n1CQnhH92k1lX9aa+0/S86L3FBqGGmrngmRM+oY30X XGE7MHmu5QNGUbIMkP7Ts5UrPtH1j1jkdWshu0r9ifRJ3Hi3l5N2HTAlj/6I6/EaC9GKxyd8/7M HbbmSQcNb0pj/gKNZUghfBIbyMUMgRirjG718lFdNJ6coeR8yqMSwSmppHFLJOfCMF2+uP50VnX s+m99gxQmh/eUn98rsQi2suSV3GGDY6DsYNwjvEYFMhcBGGG9U/7UrgQ1TzbbZiw== X-Received: by 2002:a17:903:3884:b0:2ae:6092:8d93 with SMTP id d9443c01a7336-2bc7aa398c4mr17738045ad.28.1778320567560; Sat, 09 May 2026 02:56:07 -0700 (PDT) Received: from localhost.localdomain ([106.0.59.249]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d3fed8sm48819345ad.27.2026.05.09.02.56.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 02:56:07 -0700 (PDT) From: Sajal Gupta To: petkan@nucleusys.com Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, linux-usb@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Sajal Gupta Subject: [PATCH net-next v2] net: usb: pegasus: replace simple_strtoul with kstrtouint Date: Sat, 9 May 2026 15:21:48 +0530 Message-ID: <20260509095518.2640-1-sajal2005gupta@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit simple_strtoul() is deprecated as it has no error checking. Replace it with kstrtouint() which returns an error code on invalid input, and add appropriate error handling. Also add a NULL check before parsing flags, since strsep() can set id to NULL if the input has fewer tokens than expected. Preserve the original behavior for a trailing colon by checking *id before parsing flags, so an empty string results in flags = 0 rather than an error. Signed-off-by: Sajal Gupta --- Changes in v2: - Drop err variable - Preserve original behavior for trailing colon by checking *id before parsing flags v1: https://lore.kernel.org/netdev/20260506152653.52329-1-sajal2005gupta@gmail.com/ drivers/net/usb/pegasus.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-) diff --git a/drivers/net/usb/pegasus.c b/drivers/net/usb/pegasus.c index db85f40734d7..8700eeb8e22d 100644 --- a/drivers/net/usb/pegasus.c +++ b/drivers/net/usb/pegasus.c @@ -1328,14 +1328,18 @@ static void __init parse_id(char *id) unsigned int vendor_id = 0, device_id = 0, flags = 0, i = 0; char *token, *name = NULL; - if ((token = strsep(&id, ":")) != NULL) + token = strsep(&id, ":"); + if (token) name = token; /* name now points to a null terminated string*/ - if ((token = strsep(&id, ":")) != NULL) - vendor_id = simple_strtoul(token, NULL, 16); - if ((token = strsep(&id, ":")) != NULL) - device_id = simple_strtoul(token, NULL, 16); - flags = simple_strtoul(id, NULL, 16); + token = strsep(&id, ":"); + if (token && kstrtouint(token, 16, &vendor_id)) + return; + token = strsep(&id, ":"); + if (token && kstrtouint(token, 16, &device_id)) + return; + if (id && *id && kstrtouint(id, 16, &flags)) + return; pr_info("%s: new device %s, vendor ID 0x%04x, device ID 0x%04x, flags: 0x%x\n", driver_name, name, vendor_id, device_id, flags); -- 2.54.0