Linux USB
 help / color / mirror / Atom feed
From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: "Thomas Weißschuh" <linux@weissschuh.net>
Cc: Andreas Noever <andreas.noever@gmail.com>,
	Mika Westerberg <westeri@kernel.org>,
	Yehezkel Bernat <YehezkelShB@gmail.com>,
	"David S. Miller" <davem@davemloft.net>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Michael Jamet <michael.jamet@intel.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Yehezkel Bernat <yehezkel.bernat@intel.com>
Subject: Re: [PATCH 0/6] thunderbolt: property: Fix property parsing on big-endian
Date: Mon, 25 May 2026 11:35:29 +0200	[thread overview]
Message-ID: <20260525093529.GK8580@black.igk.intel.com> (raw)
In-Reply-To: <20260524-thunderbolt-big-endian-v1-0-6044edca78e7@weissschuh.net>

Hi,

On Sun, May 24, 2026 at 03:06:42PM +0200, Thomas Weißschuh wrote:
> The parsing logic currently only works on little-endian.
> Also make it work on big-endian.

I'm all in making it more portable. Do you have big-endian hardware with
USB4 support or you are just doing so to cover some future hardware? Also
how did you test this?

> The first four patches are necessary to make the parsing work on
> big-endian machines. The remaining ones are some trivial cleanups.
> 
> Based on thunderbolt/fixes.

I suggest basing on my next branch because these are really not
regressions, rather you are "improving" the code (and I prefer to keep
these longer in linux-next so that we could catch any unintended
side-effects).

> Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
> ---
> Thomas Weißschuh (6):
>       thunderbolt: test: Make root_directory independent of host byte order
>       thunderbolt: property: Unify format_dwdata()/parse_dwdata()
>       thunderbolt: property: Make format_dwdata() work on big-endian systems
>       thunderbolt: property: Convert byte order of numeric fields
>       thunderbolt: property: Unify parse_dwdata()/format_dwdata()
>       thunderbolt: property: Make entry key modifications more visible
> 
>  drivers/thunderbolt/property.c |  93 ++++++++++++++++++------------------
>  drivers/thunderbolt/test.c     | 106 ++++++++++++++++++++---------------------
>  2 files changed, 100 insertions(+), 99 deletions(-)
> ---
> base-commit: 6ff00aaa856d16015e5bafbcf89e3998fd4a7c2b
> change-id: 20260524-thunderbolt-big-endian-9f012cfc062b
> 
> Best regards,
> --  
> Thomas Weißschuh <linux@weissschuh.net>

  parent reply	other threads:[~2026-05-25  9:35 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-24 13:06 [PATCH 0/6] thunderbolt: property: Fix property parsing on big-endian Thomas Weißschuh
2026-05-24 13:06 ` [PATCH 1/6] thunderbolt: test: Make root_directory independent of host byte order Thomas Weißschuh
2026-05-24 13:06 ` [PATCH 2/6] thunderbolt: property: Unify format_dwdata()/parse_dwdata() Thomas Weißschuh
2026-06-03  0:19   ` Andy Shevchenko
2026-05-24 13:06 ` [PATCH 3/6] thunderbolt: property: Make format_dwdata() work on big-endian systems Thomas Weißschuh
2026-06-03  0:21   ` Andy Shevchenko
2026-05-24 13:06 ` [PATCH 4/6] thunderbolt: property: Convert byte order of numeric fields Thomas Weißschuh
2026-05-24 13:06 ` [PATCH 5/6] thunderbolt: property: Unify parse_dwdata()/format_dwdata() Thomas Weißschuh
2026-06-03  0:23   ` Andy Shevchenko
2026-05-24 13:06 ` [PATCH 6/6] thunderbolt: property: Make entry key modifications more visible Thomas Weißschuh
2026-06-03  0:25   ` Andy Shevchenko
2026-05-25  9:35 ` Mika Westerberg [this message]
2026-05-25 10:32   ` [PATCH 0/6] thunderbolt: property: Fix property parsing on big-endian Thomas Weißschuh

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260525093529.GK8580@black.igk.intel.com \
    --to=mika.westerberg@linux.intel.com \
    --cc=YehezkelShB@gmail.com \
    --cc=andreas.noever@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=davem@davemloft.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=linux@weissschuh.net \
    --cc=michael.jamet@intel.com \
    --cc=westeri@kernel.org \
    --cc=yehezkel.bernat@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox