From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oo1-f47.google.com (mail-oo1-f47.google.com [209.85.161.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5AB4393DC0 for ; Mon, 25 May 2026 20:26:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.161.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779740778; cv=none; b=WVs6fFEP0YPMMrkiaMvIjlVZfMnGOFdJ+YjtlF2jNtCwwV2ambBNHk3/HRcoGA3etArCT88gPvSljqMFLE6PEhuSDgDhWk8cMcVBMAgibgTLE7n+SXYeqSat2xpl2+dQjAsgdZ9d8uY5DzQerhkhFPiWmQv6xlTHBePefiJ8xdU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779740778; c=relaxed/simple; bh=grdFfHOkHxTLhLsS6j+FX41ur/btn/7guyqiP83xFg0=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rs6B5dc7hOUcGva+WyNE09/bwH8xQEFTqPyaG9o4vIYG9zPNHqueWHqAzYqM/+xnZPVICRUVnj0y8faV/s+EWdCXUMozL7EkqQsiqtzunuD3XV7Hm0R7yFUuqJMFm4fuYe8muZsfYfYxyh+QhrABNcCLIb+AVNHsLM0nVDU5ALQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QVaMy6HK; arc=none smtp.client-ip=209.85.161.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QVaMy6HK" Received: by mail-oo1-f47.google.com with SMTP id 006d021491bc7-69d7b0be328so1365619eaf.0 for ; Mon, 25 May 2026 13:26:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1779740775; x=1780345575; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=tfK7e3u1o6Z9pLVZ7VLBuH4tZqriU9FnwEkSwlD5KZ8=; b=QVaMy6HKajbrUeuGQDYTeIaXXtInRbwb0I8OReAxc0GpJ5jR0rz0ByU/e1rKfUfPzM mIk6DK85dgmae4PfyEco+6rYhUNBXUM8+S4Oz4ms0RYxcIzMKp8+7SAS2NDzN4UyIcxY rE+C7pF1qQfh3+ocTAS3PFb62eUuP5XGQccW2UvaMXcV5yjPqmIsxXySE0o3SB1h+VPX sVGxiXnVSrwYFMuSeHMqp9K7TPzc99iszVJHaMQ7Es0S5mVXyNE0iHFo5dJyJAd0R4uF gEv2UiYE42ILISEYp+2hXUWSZ+EP1kSljdTSd9ieO8O8M4baakTnZjyvIaaeG2RqR/Gj Mn3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779740775; x=1780345575; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tfK7e3u1o6Z9pLVZ7VLBuH4tZqriU9FnwEkSwlD5KZ8=; b=DF1RHoOQ+REibN8KASC09nj0M+RVoiqGuE3Ci5/CCbHrUoofCisqJIjB/6eAqq+2bd 7NPILftV2XYxdUCj1WxHKNZoxdyISsN7ONWfxCdM1iWTeBp7Dujb4nct8aCcjloiuvRp 8N1xfv51NwIhL0ghuKAtQn9REZVap71Umxfgz76Tcz3Zcz0y/YyU+tdIks8bnciXzFbl OJ0V2Ai1sNZ4Sn+31QBK1L++VwXKG+yaQi72vh6YaFv8wF6H8w2osmhr75jIJQVwTFdE wBGegi276RoNblvjc7V6Ec+EEvkKMK5g1/nGNPk/gibKAKVSiznl40sSQDTPvtISFLqE ZEgg== X-Gm-Message-State: AOJu0YwAvBnLu6GAk2nFwj2SaHJPo2EvXZC+SqgciH0LkDekAxfF7YMZ QRNFRaCuGY369fAgtN2/2N92x9UqF32Wg0vY/fl6sALk60urvjZcaE70y7mWblUiflg= X-Gm-Gg: Acq92OFSLoP5MhSbRFIfE+OvVEXPRlloLZhwnVoz/y+/CfK4R6x2+h5iakpG5CD3EP0 tmD6av7P9aeghKylDgXd65ad1qOqtn0+fcvA1VVDQGQGTY4yQzguINqKbotp4PLLUH/o8pBwEnY dJ7mQevbgl7C/vQlJhUdmMG22/Pk5Te6sS2HHSPw6ud49i9D64JWbEoh2x72RWgLkxYvVmwlPIC AvbwzMLab1iN0W+BjT5RSY0GZAnKsETfmkUYYidB1BH/6Oes8PQd2zJdn7RHBZnJJdyR1DSVPeH k/toCZogzYPk5t4Qnh8/0Y2X8j9iHHlhO66E3GQbSNBfzMmkYttElfHSK2VNiEZpDTsi2IafRK7 nOsU0ScS8Sz6ZAqkhJFS80RM3/7gF3yl1apK9uC+3/piv6gZY5EZNqKgZtRBEIP97SGYBsEphbJ 1NoiftfQQ8dplaO0SB/S4B3gkjjqPGl/T97rDd3MBJUarqytLNFkT1o+cuwIXMGEFqLuT3Bhr2L 9/U/3vBGMyaMRinQ/+9QMnunlhsmLW0CYOVqFP3alKORZ8= X-Received: by 2002:a05:6820:1888:b0:69d:95d6:2629 with SMTP id 006d021491bc7-69d95d62775mr5413206eaf.26.1779740775642; Mon, 25 May 2026 13:26:15 -0700 (PDT) Received: from DESKTOP-J47FREO.mynetworksettings.com (171.sub-75-196-24.myvzw.com. [75.196.24.171]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-43b63512d63sm10898192fac.2.2026.05.25.13.26.14 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 25 May 2026 13:26:15 -0700 (PDT) From: Adrian Korwel To: linux-usb@vger.kernel.org Cc: gregkh@linuxfoundation.org, stable@vger.kernel.org, heikki.krogerus@linux.intel.com, Adrian Korwel Subject: [PATCH 1/4] usb: gadget: f_uac1_legacy: fix file handle leaks in gaudio_open_snd_dev() Date: Mon, 25 May 2026 15:26:09 -0500 Message-ID: <20260525202612.680-1-adriank20047@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <2026052517-undergrad-reformat-44bc@gregkh> References: <2026052517-undergrad-reformat-44bc@gregkh> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit gaudio_open_snd_dev() opens the ALSA control device file first, then opens the PCM playback device. On two error paths the control file handle is leaked: When filp_open() for the playback device fails, the function returns immediately without closing the already-opened control file handle. When playback_default_hw_params() fails, its return value was ignored and both the playback and control file handles were leaked. Both leaks result in gaudio_cleanup() calling filp_close() on already freed file objects, causing a use-after-free. Fix by closing previously opened file handles before returning on each error path, and by checking the return value of playback_default_hw_params(). Fixes: d355339eecd9 ("usb: gadget: function: make current f_uac1 implementation legacy") Cc: stable@vger.kernel.org Signed-off-by: Adrian Korwel --- drivers/usb/gadget/function/u_uac1_legacy.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/function/u_uac1_legacy.c b/drivers/usb/gadget/function/u_uac1_legacy.c index 01016102fa17..5bcd3afd6366 100644 --- a/drivers/usb/gadget/function/u_uac1_legacy.c +++ b/drivers/usb/gadget/function/u_uac1_legacy.c @@ -226,12 +226,20 @@ static int gaudio_open_snd_dev(struct gaudio *card) ERROR(card, "No such PCM playback device: %s\n", fn_play); snd->filp = NULL; + filp_close(card->control.filp, NULL); + card->control.filp = NULL; return ret; } pcm_file = snd->filp->private_data; snd->substream = pcm_file->substream; snd->card = card; - playback_default_hw_params(snd); + if (playback_default_hw_params(snd) < 0) { + filp_close(snd->filp, NULL); + snd->filp = NULL; + filp_close(card->control.filp, NULL); + card->control.filp = NULL; + return -EINVAL; + } /* Open PCM capture device and setup substream */ snd = &card->capture; -- 2.43.0