From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f47.google.com (mail-wr1-f47.google.com [209.85.221.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 294B43E2ABF for ; Tue, 2 Jun 2026 13:04:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780405498; cv=none; b=YXZp64o/o6WV0r5lAd51/TIDX9HX/CoGxQ1SpaEQivcGyNlci9p1M0jQoqIUUXjiD3jvE9WVgIFfJ4YAYYUpdBDfgWPyJRGpogjIhbEYsXyU0xluyFGeGgHDA5S3perN8XLKBtD9NwdrQUectxO+Nl4ZA6AUHTVbf5NVR3c4TTo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1780405498; c=relaxed/simple; bh=Lv88enNvVjptEHx4RPDpSYkoiYl4NHCAht/k1YwYRy4=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=CgzmWeCfhvXcKbw7ARnTK2va1j2OgZTrmafnhH1G99D3ErgQkFNVsmA4jCfMF3G31wSknCDGk8x7I+Peg+QIlGJUqxxSUHQVXInLH758wMSQdUFu6rW6updCXnR9ngkwb6dMXOlL0eWS1gC6qudZXD4zco9CPSG2w/H5BZxH6cc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=oYCy8oWL; arc=none smtp.client-ip=209.85.221.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="oYCy8oWL" Received: by mail-wr1-f47.google.com with SMTP id ffacd0b85a97d-45fd461e4a5so2275812f8f.0 for ; Tue, 02 Jun 2026 06:04:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1780405496; x=1781010296; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=H/8nMdqnIqVIuE86ZCCEmz0EQ1iXOszPXfKX9VZoGH4=; b=oYCy8oWLEOXs3ZZpnQ8VOQHoNFjKZT62/QUyW3df6kxvDecqCOK07UnU98cT9bih7d QifFlcWIr+EJiA3Y4YekpYVbMWMA0XqQZb9m0aNzEy+n6CZ9KNJxUBct5gbgm0d6jBJX 4RYm7cSM4Fa+MgP775wpjzUTJB2NacljxFREy0lFq+bJunDJIYp2ZV4sTIDkO+Vc1xr7 FpcRQcE1R3qM6zq5aytz97WBpu5zXpd39pgEA0GnDnl2ujkjmEdAdRZhqHjKWr+k4Lc4 ry5o67NwkoWSsT9Lap7TwhGHQwNn20aUpkBNKTwaaKQ1kQ2Jb1T0oTaxOfTVux7BZHHQ 5nZw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1780405496; x=1781010296; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=H/8nMdqnIqVIuE86ZCCEmz0EQ1iXOszPXfKX9VZoGH4=; b=lRIyhU93Yem2uevlcqnb5QTsw2IkhFLCtEcE+UDwlqMGAxfQnZ1UPFdVihERirjFN0 p0QVUU+LRNlxHFbFhR+EnDUX5ptwGuMPe5wv4+RwgW6/m+uqAvfteivkdeRjW+wexYN+ 0ASPUVcBKcl6wN8x5mNTcKtme9YSyTTBqkQ8fPEEst0ri8RfX/QsA+MPUE26sDhpjXI3 vtvP8Q5FgvFDnB7I1wKGGZUIjWYSJ+KC1C+ePVTsyDELjRxanYfbDrwZtj6jF2OuoeoZ xsYlP8TYzus5991kKfC0sJGYq3yIxbKyVuF6w1L7PshrnexjhZ7PcqA8d9Ry1DHCF4ji c07A== X-Forwarded-Encrypted: i=1; AFNElJ9pUfUOkXgGTftllYw3LCLDzC8msvHP98OpZX+appTvYuHsDo3w1CApT7JzxUEV/KFnoZZqz78DBRc=@vger.kernel.org X-Gm-Message-State: AOJu0YzYMEqLiMChlZKDuXYxII9gOWCDGKRXR+taTvTMBCKiuTtaf+3m dr6HNAoI8dKy/wOXd8BsHy26mLSCFD33gooK4oJ3Zpkh8eKQ6S1MPegv X-Gm-Gg: Acq92OFjbrpe5IS7O3wf08NlyHGCmmU/MqM1ezwj8DKwzB0kv7r530Ino+1dLhvCX95 aaXxdF6cYKL8zkiA1sOZH286S23NVGA0Sz5yA4RCQIF+og0HXtU9ek/iqJFtMCHnXYEKQUFnD2J Gs4zCJw359WnLrCNIiIazQIfZ7ZlO6XpEO56io/Rw3warC6PZ+bN2rYXzMZmqjhImduFqjiLvGA Dl/xSJar7pmRDO+I0aX/92S7dMMgxdq00PWY+7RlQLgHWqw3m71A+YT9YBC3l8sbVIrh7Ucs5ws x1wyT6MKgrN306w9ujizYjBHxbWwkh5rZW5MR/rqqb2Q3+hIyVFAUwdjO/d3x0VB5LxV0q4MClG IlzLJv8PIQBE30RDz13Cfe/LDi9Ef4OHuhOcYmeDKgrqPEuOmB2xuj55k1N+6vWWXbDqBXxeMLj 9Y+XCXVVyahqwlQQYYXXy/QEakAdMvDLcl4fRwc59F/dt8oTKDN+UhMSXi+4D7qgLDXqTrwRmTu ky1B8/xeA== X-Received: by 2002:a05:600c:8105:b0:490:b072:1be6 with SMTP id 5b1f17b1804b1-490b0721e0amr76565325e9.25.1780405495119; Tue, 02 Jun 2026 06:04:55 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45ef34b834esm33184301f8f.11.2026.06.02.06.04.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 02 Jun 2026 06:04:54 -0700 (PDT) Date: Tue, 2 Jun 2026 14:04:51 +0100 From: David Laight To: Andy Shevchenko Cc: Kees Cook , Luis Chamberlain , Pengpeng Hou , stable@vger.kernel.org, Petr Pavlu , Richard Weinberger , Anton Ivanov , Johannes Berg , "Rafael J. Wysocki" , Len Brown , Corey Minyard , Gabriel Somlo , "Michael S. Tsirkin" , Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , Tvrtko Ursulin , David Airlie , Simona Vetter , Bart Van Assche , Jason Gunthorpe , Leon Romanovsky , Laurent Pinchart , Hans de Goede , Mauro Carvalho Chehab , Bjorn Helgaas , Hannes Reinecke , "James E.J. Bottomley" , "Martin K. Petersen" , Daniel Lezcano , Zhang Rui , Lukasz Luba , Greg Kroah-Hartman , Jiri Slaby , Alan Stern , Jason Wang , Xuan Zhuo , Eugenio =?UTF-8?B?UMOpcmV6?= , Jason Baron , Jim Cromie , Tiwei Bie , Benjamin Berg , Ilpo =?UTF-8?B?SsOkcnZpbmVu?= , "David E. Box" , "Maciej W. Rozycki" , Srinivas Pandruvada , Peter Zijlstra , Heiko Carstens , Vasily Gorbik , Sean Christopherson , Paolo Bonzini , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" , Vinod Koul , Frank Li , Daniel Gomez , Sami Tolvanen , Aaron Tomlin , Alexander Potapenko , Marco Elver , Dmitry Vyukov , Andrew Morton , John Johansen , Paul Moore , James Morris , "Serge E. Hallyn" , Georgia Garcia , kvm@vger.kernel.org, dmaengine@vger.kernel.org, linux-modules@vger.kernel.org, kasan-dev@googlegroups.com, linux-mm@kvack.org, apparmor@lists.ubuntu.com, linux-security-module@vger.kernel.org, linux-um@lists.infradead.org, linux-acpi@vger.kernel.org, openipmi-developer@lists.sourceforge.net, qemu-devel@nongnu.org, intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, linux-media@vger.kernel.org, linux-pci@vger.kernel.org, linux-scsi@vger.kernel.org, linux-pm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, linux-serial@vger.kernel.org, linux-usb@vger.kernel.org, usb-storage@lists.one-eyed-alien.net, virtualization@lists.linux.dev, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, netdev@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-hardening@vger.kernel.org Subject: Re: [PATCH 01/11] params: bound array element output to the caller's page buffer Message-ID: <20260602140451.2e3e6622@pumpkin> In-Reply-To: References: <20260521133315.work.845-kees@kernel.org> <20260521133326.2465264-1-kees@kernel.org> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Tue, 2 Jun 2026 14:26:46 +0300 Andy Shevchenko wrote: > On Thu, May 21, 2026 at 06:33:14AM -0700, Kees Cook wrote: > > > > param_array_get() appends each element's string representation into the > > shared sysfs page buffer by passing buffer + off to the element getter. > > > > That works for getters that only write a small bounded string, but > > param_get_charp() and similar helpers format against PAGE_SIZE from the > > pointer they receive. Once off is non-zero, an element getter can > > therefore write past the end of the original sysfs page buffer. > > > > Collect each element into a temporary PAGE_SIZE buffer first and then > > copy only the remaining space into the caller's page buffer. > > ... > > > + elem_buf = kmalloc(PAGE_SIZE, GFP_KERNEL); > > get_free_page() (or how it is called)? The kmalloc() should be faster and I think has to be aligned. There is another patch set to replace get_free_pages() with kmalloc(). Although all these 'show' functions should really head to using a safer interface. Although, at the moment, it is really difficult to find the ones that are guaranteed to be passed a page aligned buffer. -- David > > > + if (!elem_buf) > > + return -ENOMEM; > > + > > for (i = off = 0; i < (arr->num ? *arr->num : arr->max); i++) { > > - /* Replace \n with comma */ > > - if (i) > > - buffer[off - 1] = ','; > > p.arg = arr->elem + arr->elemsize * i; > > check_kparam_locked(p.mod); > > - ret = arr->ops->get(buffer + off, &p); > > + ret = arr->ops->get(elem_buf, &p); > > if (ret < 0) > > - return ret; > > + goto out; > > + ret = min(ret, (int)(PAGE_SIZE - 1 - off)); > > It's usually discouraged to use castings in min/max/clamp. Can we make ret long > or do something different here? > > > + if (!ret) > > + break; > > > + /* Replace the previous element's trailing newline with a comma. */ > > + if (i) > > + buffer[off - 1] = ','; > > Can't we do this after with help of strreplace()? > > > + memcpy(buffer + off, elem_buf, ret); > > off += ret; > > + if (off == PAGE_SIZE - 1) > > + break; > > } > > buffer[off] = '\0'; > > - return off; > > + ret = off; > > +out: > > + kfree(elem_buf); > > + return ret; >