From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: raoxu <raoxu@uniontech.com>
Cc: andreas.noever@gmail.com, westeri@kernel.org,
YehezkelShB@gmail.com, linux-usb@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] thunderbolt: debugfs: fix sideband write size check
Date: Mon, 8 Jun 2026 12:48:46 +0200 [thread overview]
Message-ID: <20260608104846.GK2990@black.igk.intel.com> (raw)
In-Reply-To: <E4D8CB8444A9950B+20260608063147.794444-1-raoxu@uniontech.com>
On Mon, Jun 08, 2026 at 02:31:47PM +0800, raoxu wrote:
> From: Xu Rao <raoxu@uniontech.com>
>
> sb_regs_write() looks up the matching sideband register entry before
> validating the number of bytes to write.
>
> However, the size check uses sb_regs->size, which is the size of the
> first entry in the register table, instead of the matched entry. This
> rejects valid writes to larger sideband registers such as USB4_SB_DEBUG
> or USB4_SB_DATA.
>
> Use the matched register entry for the size check.
>
> Signed-off-by: Xu Rao <raoxu@uniontech.com>
Applied to thunderbolt.git/next, thanks!
prev parent reply other threads:[~2026-06-08 10:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-08 6:31 [PATCH] thunderbolt: debugfs: fix sideband write size check raoxu
2026-06-08 10:48 ` Mika Westerberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260608104846.GK2990@black.igk.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=YehezkelShB@gmail.com \
--cc=andreas.noever@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=raoxu@uniontech.com \
--cc=westeri@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox