From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BCEED27816C; Tue, 9 Jun 2026 13:20:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781011205; cv=none; b=F3KgpOSGy5sLn15inMq1rxf35SbDnn0fGz4R2D027gCHU10tb1fdM9pJv3ca4xPvxuJdhzB9C3INJZtuHkUdI/1nwzmqoygGYLAERfK4yAwQjcnbOrrMQQJlX+lAkvxvjmRYu+esMB2l5jGDz4smYV0FKxNefwgM09nCHrDJvT4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781011205; c=relaxed/simple; bh=pi5T/eK4OWz3QgGvWYsk5tIe6n4hsKPcMz2Tbf5hr6Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=k0FhY9okz+kDXy1xW/4E3+Ovj4TUgXugYDqoRS4Xrd2IYg5RIkc0rZLV8aF+Wolf0ldMGd6F3k8sz5hrD2FFWZLwlwon6qPb7axDz9jvdL2J/w8VBaLvBBidxgJKd/HsqcNAlTxlERywP9Cwnqgf//8t80momCGWBGSxP8z8O7w= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Nu3c//Al; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nu3c//Al" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A5F451F0089B; Tue, 9 Jun 2026 13:20:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1781011204; bh=3kfzfYUQjmzrzaNngkfG7jEfCJtYkrmcPuvtAzgJevo=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=Nu3c//AlzSp8dePkkxInyBwOH1za16zBtOfwyKKYtLFFLjiG8i4p3lxnz7/woXZRt JtKfFb9rqoH+SnrrC4q2iV44PdZ/9zVTsMNh6FhyvEl7aeFW7q1jiKXD0iYDuZT/19 WAoTm2OfHpFKUjwDV7p3e1NXD1LDpjNUjE5OJ0BXTDAqSNdwXFpcotHjICirfRcDqq gXCCws+Lwj8qzUFh7jDIZdWSsogSZOcJi186LTV8ZYFAGhPuAZOcImMurdCnIqzQ5X HlfUlKnoNl7MCbPDCPLxB+eDFsxDgAHMilxw3DMD1rCWpElmqaPJkEJURsALDig2p1 sWS4POf/gNapw== Date: Tue, 9 Jun 2026 15:20:01 +0200 From: Maxime Ripard To: Dmitry Baryshkov Cc: Maarten Lankhorst , Thomas Zimmermann , David Airlie , Simona Vetter , Heikki Krogerus , Greg Kroah-Hartman , Andrzej Hajda , Neil Armstrong , Robert Foss , Laurent Pinchart , Jonas Karlman , Jernej Skrabec , Adrien Grassein , Jani Nikula , Rodrigo Vivi , Joonas Lahtinen , Tvrtko Ursulin , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , Rob Clark , Dmitry Baryshkov , Abhinav Kumar , Jessica Zhang , Sean Paul , Marijn Suijten , Tomi Valkeinen , Bjorn Andersson , Konrad Dybcio , Pengyu Luo , Nikita Travkin , Yongxing Mou , Luca Ceresoli , Francesco Dolcini , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, intel-gfx@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-amlogic@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org Subject: Re: [PATCH v4 1/8] drm/connector: report out-of-band IRQ_HPD events Message-ID: <20260609-bouncy-tomato-dalmatian-70ccee@houat> References: <20260608-hpd-irq-events-v4-0-30b62b335487@oss.qualcomm.com> <20260608-hpd-irq-events-v4-1-30b62b335487@oss.qualcomm.com> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha384; protocol="application/pgp-signature"; boundary="25e53fw4vpfchyki" Content-Disposition: inline In-Reply-To: <20260608-hpd-irq-events-v4-1-30b62b335487@oss.qualcomm.com> --25e53fw4vpfchyki Content-Type: text/plain; protected-headers=v1; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v4 1/8] drm/connector: report out-of-band IRQ_HPD events MIME-Version: 1.0 Hi, On Mon, Jun 08, 2026 at 12:33:02AM +0300, Dmitry Baryshkov wrote: > The DisplayPort standard defines a special kind of events called IRQ. > These events are used to notify DP Source about the events on the Sink > side. It is extremely important for DP MST handling, where the MST > events are reported through this IRQ. >=20 > In case of the USB-C DP AltMode there is no actual HPD pulse, but the > events are reported through the bits in the AltMode VDOs. >=20 > Rename drm_connector_oob_hotplug_event() to drm_connector_dp_oob_status() > and extend its interface to report IRQ events to the DisplayPort Sink > drivers. >=20 > Acked-by: Heikki Krogerus > Signed-off-by: Dmitry Baryshkov > --- > drivers/gpu/drm/drm_connector.c | 20 ++++++++++++-------- > drivers/usb/typec/altmodes/displayport.c | 23 +++++++++++++++-------- > include/drm/drm_connector.h | 21 +++++++++++++++++++-- > 3 files changed, 46 insertions(+), 18 deletions(-) >=20 > diff --git a/drivers/gpu/drm/drm_connector.c b/drivers/gpu/drm/drm_connec= tor.c > index 3fa4d2082cd7..bb128dd0263a 100644 > --- a/drivers/gpu/drm/drm_connector.c > +++ b/drivers/gpu/drm/drm_connector.c > @@ -3502,20 +3502,24 @@ struct drm_connector *drm_connector_find_by_fwnod= e(struct fwnode_handle *fwnode) > } > =20 > /** > - * drm_connector_oob_hotplug_event - Report out-of-band hotplug event to= connector > + * drm_connector_dp_oob_status - Report out-of-band hotplug event to Dis= playPort connector > * @connector_fwnode: fwnode_handle to report the event on > * @status: hot plug detect logical state > + * @extra_status: additional information provided by the sink without ch= anging > + * the HPD state (or in addition to such a change). > * > - * On some hardware a hotplug event notification may come from outside t= he display > - * driver / device. An example of this is some USB Type-C setups where t= he hardware > - * muxes the DisplayPort data and aux-lines but does not pass the altmod= e HPD > - * status bit to the GPU's DP HPD pin. > + * In some cases when DisplayPort signals are being routed through the U= SB > + * Type-C port the hotplug event notifications come from outside of the = display > + * driver / device. In this case hardware muxes the DisplayPort data and > + * AUX-lines but does not pass the altmode HPD status bit to the GPU's D= P HPD > + * pin. > * > * This function can be used to report these out-of-band events after ob= taining > * a drm_connector reference through calling drm_connector_find_by_fwnod= e(). > */ > -void drm_connector_oob_hotplug_event(struct fwnode_handle *connector_fwn= ode, > - enum drm_connector_status status) > +void drm_connector_dp_oob_status(struct fwnode_handle *connector_fwnode, > + enum drm_connector_status status, > + enum drm_connector_status_extra extra_status) Thanks for the renaming, but I think we can also rename drm_connector_status_extra to something a bit more descriptive now? drm_connector_dp_oob_event? status? The rest looks good. Maxime --25e53fw4vpfchyki Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iJUEABMJAB0WIQTkHFbLp4ejekA/qfgnX84Zoj2+dgUCaigTAQAKCRAnX84Zoj2+ dnv2AX9le3hz+Lu8gxYvgEXc1sDIBCPM1bh/zkVwBN3wZ9THVMA3l8RMscsHED+I ZdjXquUBeQESub4sfU2kH0nggZa7VB2wC1SqcPxTrCSdEwKVl5n4RlSMJ/F47hOK i6kZa+CMlQ== =wSKV -----END PGP SIGNATURE----- --25e53fw4vpfchyki--