Re: [PATCH v3] thunderbolt: Assert downstream port reset on shutdown

[Mika Westerberg <mika.westerberg@linux.intel.com>]

Hi,

On Wed, Jun 10, 2026 at 10:19:29PM +0530, Basavaraj Natikar wrote:
> Sounds good, I'll go with that structure and name the driver hook
> nhi_pci_shutdown(). One note: I kept the flag rather than threading a
> 'reset' parameter down, because tb_stop() needs the stored
> nhi->host_reset for the unload case anyway (the host_reset module param
> is static in nhi.c and not visible in tb_stop()), and passing a parameter
> would also change tb_domain_remove() and the cm_ops->stop() signature
> shared with icm.c. So:
> 
>   - nhi_pci_shutdown (tb_nhi_ops handler) -> nhi_pci_release_irq()
>   - nhi_pci_do_remove(pdev, reset): sets nhi->host_reset = true when
>     'reset', then does the usual removal
>   - nhi_pci_remove()   -> nhi_pci_do_remove(pdev, false)
>   - nhi_pci_shutdown() -> nhi_pci_do_remove(pdev, true)   (the ->shutdown hook)
> tb_stop() keeps checking nhi->host_reset.
> 
> Please let me know if this looks fine and I'll send v4.

Looks okay to me.