From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Rosen Penev <rosenp@gmail.com>
Cc: linux-usb@vger.kernel.org, Bastien Nocera <hadess@hadess.net>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] usb: apple-mfi-fastcharge: Convert to devm resources
Date: Sun, 14 Jun 2026 05:40:33 +0200 [thread overview]
Message-ID: <2026061403-lion-pregnant-b6e3@gregkh> (raw)
In-Reply-To: <20260613201851.63191-1-rosenp@gmail.com>
On Sat, Jun 13, 2026 at 01:18:51PM -0700, Rosen Penev wrote:
> Use devm_kzalloc(), devm_kasprintf(), and devm_power_supply_register()
> to let the driver core handle resource cleanup. This allows removing
> the mfi_fc_disconnect() function and the error labels in probe.
Please don't do this on old drivers unless you have the hardware to test
that the change worked properly.
> Also take the opportunity to shrink the private struct and move the
> variables in probe as devm doesn't need them in the struct.
Shouldn't this be a separate change?
thanks,
greg k-h
next prev parent reply other threads:[~2026-06-14 3:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-13 20:18 [PATCH] usb: apple-mfi-fastcharge: Convert to devm resources Rosen Penev
2026-06-14 3:40 ` Greg Kroah-Hartman [this message]
2026-06-14 3:45 ` Rosen Penev
2026-06-14 3:56 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026061403-lion-pregnant-b6e3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hadess@hadess.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=rosenp@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox