Linux USB
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Leonid Konontsov <lkonontsov@gmail.com>
Cc: Johan Hovold <johan@kernel.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: serial: replacing mutex_lock to guard(mutex)
Date: Mon, 15 Jun 2026 04:28:32 +0200	[thread overview]
Message-ID: <2026061555-climate-phosphate-4747@gregkh> (raw)
In-Reply-To: <20260614192337.9449-1-lkonontsov@gmail.com>

On Sun, Jun 14, 2026 at 10:23:37PM +0300, Leonid Konontsov wrote:
> Moving from manual mutex_lock's and mutex_unlock's to guard(mutex) in
> ark3116.c file.

That says what you are doing, but not why.

Please don't change code to use guard() unless you are fixing a bug.
Otherwise the churn in the kernel would not be worth it.  Just use it in
new code please.

thanks,

greg k-h

  reply	other threads:[~2026-06-15  2:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-14 19:23 [PATCH] usb: serial: replacing mutex_lock to guard(mutex) Leonid Konontsov
2026-06-15  2:28 ` Greg Kroah-Hartman [this message]
2026-06-15  2:29 ` Greg Kroah-Hartman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026061555-climate-phosphate-4747@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=lkonontsov@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox