Re: [PATCH] xhci: pci: Disable soft retry for Renesas uPD720201

[Greg KH <gregkh@linuxfoundation.org>]

On Wed, Jun 17, 2026 at 04:34:54PM +0800, raoxu wrote:
> From: Xu Rao <raoxu@uniontech.com>
> 
> The Renesas uPD720201 xHCI controller can fail to complete
> a Stop Endpoint command after a transaction error on an interrupt
> endpoint when soft retry is used.
> 
> This was reproduced with this setup:
> 
>   xHCI: Renesas uPD720201, PCI ID 1912:0014 rev 03
>   dev:  USB Ethernet device with an integrated Genesys Logic
>         USB3.1 hub, USB ID 05e3:0626, and a Realtek RTL8153
>         Ethernet function, USB ID 0bda:8153
> 
> Reproducer:
> 
>   1. Plug the integrated USB hub and Ethernet device into the
>      1912:0014 xHCI controller.
>   2. Let r8152 bind to the 0bda:8153 RTL8153 Ethernet function
>      behind the integrated hub.
>   3. Bring the Ethernet device up.
>   4. Hot-unplug the device.
> 
> The host reports a transaction error on the RTL8153 interrupt
> endpoint, queues a soft reset, and later times out the Stop
> Endpoint command while disconnecting the device:
> 
>   Transfer error for slot 8 ep 6 on endpoint
>   Soft-reset ep 6, slot 8
>   Ignoring reset ep completion code of 1
>   xHCI host not responding to stop endpoint command
>   xHCI host controller not responding, assume dead
>   HC died; cleaning up
> 
> The Renesas 1912:0014 controller cannot safely use the xHCI soft
> retry path. Set XHCI_NO_SOFT_RETRY for this controller so
> transaction errors use the pre-soft-retry recovery path. With
> this quirk the same hot-unplug test no longer times out the Stop
> Endpoint command and the RTL8153 remains usable and stable.
> 
> Fixes: f8f80be501aa ("xhci: Use soft retry to recover faster from transaction errors")
> 
> Signed-off-by: Xu Rao <raoxu@uniontech.com>
> ---
>  drivers/usb/host/xhci-pci.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/usb/host/xhci-pci.c b/drivers/usb/host/xhci-pci.c
> index 585b2f3117b0..d70c6a6a64bb 100644
> --- a/drivers/usb/host/xhci-pci.c
> +++ b/drivers/usb/host/xhci-pci.c
> @@ -427,6 +427,7 @@ static void xhci_pci_quirks(struct device *dev, struct xhci_hcd *xhci)
>  	if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
>  	    pdev->device == 0x0014) {
>  		xhci->quirks |= XHCI_ZERO_64B_REGS;
> +		xhci->quirks |= XHCI_NO_SOFT_RETRY;
>  	}
>  	if (pdev->vendor == PCI_VENDOR_ID_RENESAS &&
>  	    pdev->device == 0x0015) {
> --
> 2.50.1
> 

Hi,

This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
a patch that has triggered this response.  He used to manually respond
to these common problems, but in order to save his sanity (he kept
writing the same thing over and over, yet to different people), I was
created.  Hopefully you will not take offence and will fix the problem
in your patch and resubmit it so that it can be accepted into the Linux
kernel tree.

You are receiving this message because of the following common error(s)
as indicated below:


- You have marked a patch with a "Fixes:" tag for a commit that is in an
  older released kernel, yet you do not have a cc: stable line in the
  signed-off-by area at all, which means that the patch will not be
  applied to any older kernel releases.  To properly fix this, please
  follow the documented rules in the
  Documentation/process/stable-kernel-rules.rst file for how to resolve
  this.

If you wish to discuss this problem further, or you have questions about
how to resolve this issue, please feel free to respond to this email and
Greg will reply once he has dug out from the pending patches received
from other developers.

thanks,

greg k-h's patch email bot