From: Jad Keskes <inasj268@gmail.com>
To: gregkh@linuxfoundation.org
Cc: linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Jad Keskes <inasj268@gmail.com>
Subject: [PATCH] usb: misc: cytherm: replace deprecated simple_strtoul with kstrtoint
Date: Mon, 22 Jun 2026 13:31:24 +0100 [thread overview]
Message-ID: <20260622123124.2380612-1-inasj268@gmail.com> (raw)
simple_strtoul() is deprecated in favor of kstrtoint(). The old
function silently accepts garbage input. kstrtoint() returns -EINVAL
so the driver can actually tell the user they typed something stupid
instead of accepting 0 and wondering why the thermometer isn't
responding.
The 0-255 clamping stays the same, just with proper error handling
in front of it now.
Signed-off-by: Jad Keskes <inasj268@gmail.com>
---
drivers/usb/misc/cytherm.c | 12 +++++++++---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/misc/cytherm.c b/drivers/usb/misc/cytherm.c
index b183df9826bc..81de3fecf3da 100644
--- a/drivers/usb/misc/cytherm.c
+++ b/drivers/usb/misc/cytherm.c
@@ -85,7 +85,9 @@ static ssize_t brightness_store(struct device *dev, struct device_attribute *att
if (!buffer)
return 0;
- cytherm->brightness = simple_strtoul(buf, NULL, 10);
+ retval = kstrtoint(buf, 10, &cytherm->brightness);
+ if (retval < 0)
+ return retval;
if (cytherm->brightness > 0xFF)
cytherm->brightness = 0xFF;
@@ -217,7 +219,9 @@ static ssize_t port0_store(struct device *dev, struct device_attribute *attr, co
if (!buffer)
return 0;
- tmp = simple_strtoul(buf, NULL, 10);
+ retval = kstrtoint(buf, 10, &tmp);
+ if (retval < 0)
+ return retval;
if (tmp > 0xFF)
tmp = 0xFF;
@@ -272,7 +276,9 @@ static ssize_t port1_store(struct device *dev, struct device_attribute *attr, co
if (!buffer)
return 0;
- tmp = simple_strtoul(buf, NULL, 10);
+ retval = kstrtoint(buf, 10, &tmp);
+ if (retval < 0)
+ return retval;
if (tmp > 0xFF)
tmp = 0xFF;
--
2.54.0
reply other threads:[~2026-06-22 12:31 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260622123124.2380612-1-inasj268@gmail.com \
--to=inasj268@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox