From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-alma10-1.taild15c8.ts.net [100.103.45.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9B8E733CEA2; Mon, 22 Jun 2026 16:52:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=100.103.45.18 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782147125; cv=none; b=m7duQFja7eQHu4lW779ji7JgVH5TgtlQcj8WbybBHd8/8cZ3rBWlKt+9G1rVixO4zEPipVhkbFeqcQSrZ8reMChMhBS0taleu8jmMNt8HtS+1y/dZvryrGPNE8X8UQA9k0FZlfkcypGvWkr+/yXpzb2G7pblqcpSbLirgwl82ks= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782147125; c=relaxed/simple; bh=6+P9pSwfaRh/FJ2Ae5JWmxAni7SXDOgYmFtpbfKSAtY=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=gPkpG1A6L6WLr8KWB1r6iY2fmfDeVx30ixsSRN58DUXcA1a/XkmG+Mi5AL5XnnBjwsD+pOkrrlyqHvQO1MaXb3i2aoLRoZsYkql6QPDsF60/m99eFthU7idN6zAgqozv/+SA0Df+51SQLmeG4YYt7ACjO+iQAKD6j9BUX08ates= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=C4kpffoq; arc=none smtp.client-ip=100.103.45.18 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="C4kpffoq" Received: by smtp.kernel.org (Postfix) with ESMTPSA id BF0041F000E9; Mon, 22 Jun 2026 16:51:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1782147124; bh=KXhjFgbhEvwE+7GGBfh7My0VIVq6OjTLQwMtEz0hufY=; h=Date:From:To:Cc:Subject:In-Reply-To:References; b=C4kpffoqKELHy6h2iIonBbM+lwHOlkqgrFXueJXDfdgl75fDx8nTrSA+oGiGyoeAm 8CCy0uyoOREJUge4zC6mq+dv0w+QL43toIPSNlcNAZyZKDjugsy6al/c7V2Nxly4Pl B3u0wZw90AH5q2Vforbc/8novl4n4De9d7hKEY2j9fwmOHjRuuHlA8HYlkPOQSxTMr w8OjFxrmzo3xN9JG3zdPXZhL02HItS9kysxEXgHLRRSGAVfOqOYr/WF7zxLGK20H2R AQhZ61uSQFpPSM+xdZ5/Wi01z1P5qKOyIveeDb+LOtEbWIs/Vdg1dtFfhX3DZ+GRC2 IABQXBNVHhFSA== Date: Mon, 22 Jun 2026 12:51:54 -0400 From: Steven Rostedt To: Randy Dunlap Cc: Peter Zijlstra , linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org, Masami Hiramatsu , Mark Rutland , Mathieu Desnoyers , Andrew Morton , Linus Torvalds , Sebastian Andrzej Siewior , John Ogness , Thomas Gleixner , Julia Lawall , Yury Norov , linux-doc@vger.kernel.org, linux-kbuild@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, dri-devel@lists.freedesktop.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-rdma@vger.kernel.org, linux-usb@vger.kernel.org, linux-ext4@vger.kernel.org, linux-nfs@vger.kernel.org, kvm@vger.kernel.org, intel-gfx@lists.freedesktop.org Subject: Re: [PATCH 0/2] tracing: Move trace_printk.h out of kernel.h Message-ID: <20260622125154.6f5b9b33@fedora> In-Reply-To: <08b3c961-18bb-43d9-8d7f-8a87bcad0afa@infradead.org> References: <20260621093430.264983361@kernel.org> <20260622083440.GX49951@noisy.programming.kicks-ass.net> <08b3c961-18bb-43d9-8d7f-8a87bcad0afa@infradead.org> X-Mailer: Claws Mail 4.4.0 (GTK 3.24.52; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 22 Jun 2026 09:40:45 -0700 Randy Dunlap wrote: > > Did you forget your C 101 class? If you use a function, you gotta > > include the relevant header. > > Also item #1 in Documentation/process/submit-checklist.rst. What is that? Remove all trace_printk()s before you submit? Because that is what you should do. But now you also need to remember to remove the include too. Or, I guess if someone uses it a lot, they may just keep it in their files without the trace_printk()s. -- Steve