From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "Chinna Mopurigari Naveen Kumar Reddy (FTDI-SG)"
<naveen.reddy@ftdichip.com>
Cc: Johan Hovold <johan@kernel.org>,
"linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Arun Pappan (FTDI-SG)" <arun.pappan@ftdichip.com>
Subject: Re: [PATCH 1/6] USB: serial: ftdi_sio: add configurable inter-batch defer for read URBs
Date: Mon, 22 Jun 2026 11:27:49 +0200 [thread overview]
Message-ID: <2026062229-pesky-wasabi-ae9b@gregkh> (raw)
In-Reply-To: <SG2PPFE985372F0DEC3C668B0C138E0684BEFEF2@SG2PPFE985372F0.apcprd01.prod.exchangelabs.com>
On Mon, Jun 22, 2026 at 09:05:53AM +0000, Chinna Mopurigari Naveen Kumar Reddy (FTDI-SG) wrote:
> Hi Greg,
>
> On Mon, Jun 22, 2026 at 04:52:00PM +0000, Greg Kroah-Hartman wrote:
> > This is not the 1990's, module parameters should not be used anymore...
> > Why not just fix this at the root of the problem?
>
> Thank you for the review, Greg.
>
> You are right on both points.
>
> On the module parameter: I will switch to sysfs if the per-driver approach
> is accepted, or drop it entirely.
>
> On the location: your core point is well-taken. The DMA channel starvation
> is a BCM2835 DWC_OTG host controller deficiency, and the correct fix
> belongs in the host controller driver, not in each USB device driver.
> I will investigate fixing it there instead. If that is not feasible (the
> BCM2835 DWC_OTG is a vendor tree that Broadcom/RPi maintain outside
> mainline), I will report back before proposing any per-driver workaround.
As this is an out-of-tree issue, there's nothing we can do in our
in-tree drivers for that. Please work with that team to either get
their code merged properly upstream with us, where we can all work on
the issue together, or just work with them out-of-tree.
thanks,
greg k-h
next prev parent reply other threads:[~2026-06-22 9:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-22 7:38 [PATCH 0/6] USB: serial: ftdi_sio: configurable read-URB defer, per-port low_latency, latency_timer reliability Chinna Mopurigari Naveen Kumar Reddy
2026-06-22 7:38 ` [PATCH 1/6] USB: serial: ftdi_sio: add configurable inter-batch defer for read URBs Chinna Mopurigari Naveen Kumar Reddy
2026-06-22 8:51 ` Greg Kroah-Hartman
2026-06-22 8:52 ` Greg Kroah-Hartman
2026-06-22 9:05 ` Chinna Mopurigari Naveen Kumar Reddy (FTDI-SG)
2026-06-22 9:27 ` Greg Kroah-Hartman [this message]
2026-06-22 9:43 ` Chinna Mopurigari Naveen Kumar Reddy (FTDI-SG)
2026-06-22 7:38 ` [PATCH 2/6] USB: serial: ftdi_sio: retry transient errors on chip-side control transfers Chinna Mopurigari Naveen Kumar Reddy
2026-06-22 7:38 ` [PATCH 3/6] USB: serial: ftdi_sio: make explicit latency_timer sysfs write authoritative Chinna Mopurigari Naveen Kumar Reddy
2026-06-22 7:38 ` [PATCH 4/6] USB: serial: ftdi_sio: add per-port low_latency sysfs attribute Chinna Mopurigari Naveen Kumar Reddy
2026-06-22 7:38 ` [PATCH 5/6] USB: serial: ftdi_sio: serialise low_latency toggle against read_bulk_callback Chinna Mopurigari Naveen Kumar Reddy
2026-06-22 7:38 ` [PATCH 6/6] USB: serial: ftdi_sio: pace low_latency ports with low_latency_defer_ns Chinna Mopurigari Naveen Kumar Reddy
2026-06-22 9:43 ` [PATCH v2 0/2] USB: serial: ftdi_sio: latency_timer reliability fixes Chinna Mopurigari Naveen Kumar Reddy
2026-06-22 9:43 ` [PATCH v2 1/2] USB: serial: ftdi_sio: retry transient errors on chip-side control transfers Chinna Mopurigari Naveen Kumar Reddy
2026-06-22 9:43 ` [PATCH v2 2/2] USB: serial: ftdi_sio: make explicit latency_timer sysfs write authoritative Chinna Mopurigari Naveen Kumar Reddy
2026-06-22 10:19 ` Greg Kroah-Hartman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026062229-pesky-wasabi-ae9b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=arun.pappan@ftdichip.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=naveen.reddy@ftdichip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox