From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.forwardemail.net (smtp.forwardemail.net [149.28.215.223]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 59CA4382394 for ; Wed, 24 Jun 2026 19:27:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=149.28.215.223 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782329266; cv=none; b=tzFmPrtla4lMoG/PoWwNYm87fxndnqFib0uKWFbp57s0NWQK7UG+ai8oEqli/x+0BBQz4IlLbre20GFc96uK5XDyUiEREuPAuzNq9g8bSnyPHvKj+ks35+Z8sf4XyTy8/l1TGhUMAUkJ0x8ojpgm2Q8E1AbAcmE3RUJXGwc7TGU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782329266; c=relaxed/simple; bh=9E65z7OGWd2P6qUZoSyq/lFPj2UX4EeAgZgWnF+37+c=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=qfM/sguTkCEZs0cmfsrrZEw05Q9kp1gPlCck3yMdPBp0x51wBzvtWiAgNnQ9S29BTV4n02K+6ZrHLORtODd3Gg6UKEKmtFQGTrTaFjw1xURiJ8RGVAxGt8L4nMGHUVqYZzXTrOCIeIlyywdkr6ddTo+J6JPtpw8/fl9lmicXqRw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kwiboo.se; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b=GHLvF0Cf; arc=none smtp.client-ip=149.28.215.223 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=kwiboo.se Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=fe-bounces.kwiboo.se Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kwiboo.se header.i=@kwiboo.se header.b="GHLvF0Cf" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kwiboo.se; h=Content-Transfer-Encoding: MIME-Version: References: In-Reply-To: Message-ID: Date: Subject: Cc: To: From; q=dns/txt; s=fe-e1b5cab7be; t=1782329258; bh=Z99Q29vxpTumNbDlSLV/5spk9aNhNsdFqpygOCzOZY4=; b=GHLvF0Cf0Ib7AMzBpWiUiefRL4/USozRQfehR7BPyWelcBdOO/gBHzATtWWJCjBjEoVdOMAee EI7Udfq8goeIKK1expCa2Cx6AtLYIiVjH/iDrbLiM17CxxYX1orvuIDKQJSC1tJzMxeSCTsNrp9 EoSOXmwufzVl93gm8eg+ZvbMn4vUJJBEqxzX6cDQijntu1hxJPLmgqaQ3T2aEvYlskDIw9v8SA4 7GVIKyHizaAuYuehMnPhBd41rLBw2QPU4mhOVskV/BEPCukNMJjOTze+rUY2B2Yx+Artbql8iDf zC0nfWhW9FwyN/gH5hGQYpogqWosob0aDW6H64+8lfag== X-Forward-Email-ID: 6a3c2fa5138f49c481104abd X-Forward-Email-Sender: rfc822; jonas@kwiboo.se, smtp.forwardemail.net, 149.28.215.223 X-Forward-Email-Version: 2.8.32 X-Forward-Email-Website: https://forwardemail.net X-Complaints-To: abuse@forwardemail.net X-Report-Abuse: abuse@forwardemail.net X-Report-Abuse-To: abuse@forwardemail.net From: Jonas Karlman To: Heiko Stuebner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman Cc: Diederik de Haas , devicetree@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-usb@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Jonas Karlman Subject: [PATCH v2 1/2] dt-bindings: usb: Add Rockchip RK3568 compatible for EHCI and OHCI Date: Wed, 24 Jun 2026 19:27:24 +0000 Message-ID: <20260624192726.781864-2-jonas@kwiboo.se> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260624192726.781864-1-jonas@kwiboo.se> References: <20260624192726.781864-1-jonas@kwiboo.se> Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The Rockchip RK3568 EHCI/OHCI controller depends on clk_usbphy1_480m being enabled, or the system may freeze when registers are accessed. Add Rockchip RK3568 EHCI and OHCI compatibles with a similar four-clock constraint as RK3588, also extend the EHCI constraint to include RK3588 to match similar requirements of RK3588. Signed-off-by: Jonas Karlman --- Existing DTs for RK3568 use the plain generic-ehci/ohci compatible, next patch make use of these new compatibles and adds the missing clk_usbphy1_480m clock references. Existing DTs for RK3588 have contained the required four clocks since the initial addition of the EHCI/OHCI nodes. Changes in v2: - Include rockchip,rk3588-ehci in the EHCI constraint - Make clocks prop required for EHCI and OHCI --- .../devicetree/bindings/usb/generic-ehci.yaml | 14 ++++++++++++++ .../devicetree/bindings/usb/generic-ohci.yaml | 7 ++++++- 2 files changed, 20 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/usb/generic-ehci.yaml b/Documentation/devicetree/bindings/usb/generic-ehci.yaml index 55a5aa7d7a54..a39f01e740b1 100644 --- a/Documentation/devicetree/bindings/usb/generic-ehci.yaml +++ b/Documentation/devicetree/bindings/usb/generic-ehci.yaml @@ -52,6 +52,7 @@ properties: - ibm,476gtr-ehci - nxp,lpc1850-ehci - qca,ar7100-ehci + - rockchip,rk3568-ehci - rockchip,rk3588-ehci - snps,hsdk-v1.0-ehci - socionext,uniphier-ehci @@ -186,6 +187,19 @@ allOf: required: - clocks - clock-names + - if: + properties: + compatible: + contains: + enum: + - rockchip,rk3568-ehci + - rockchip,rk3588-ehci + then: + properties: + clocks: + minItems: 4 + required: + - clocks unevaluatedProperties: false diff --git a/Documentation/devicetree/bindings/usb/generic-ohci.yaml b/Documentation/devicetree/bindings/usb/generic-ohci.yaml index d42f448fa204..19449a6b3033 100644 --- a/Documentation/devicetree/bindings/usb/generic-ohci.yaml +++ b/Documentation/devicetree/bindings/usb/generic-ohci.yaml @@ -47,6 +47,7 @@ properties: - hpe,gxp-ohci - ibm,476gtr-ohci - ingenic,jz4740-ohci + - rockchip,rk3568-ohci - rockchip,rk3588-ohci - snps,hsdk-v1.0-ohci - const: generic-ohci @@ -198,11 +199,15 @@ allOf: properties: compatible: contains: - const: rockchip,rk3588-ohci + enum: + - rockchip,rk3568-ohci + - rockchip,rk3588-ohci then: properties: clocks: minItems: 4 + required: + - clocks else: properties: clocks: -- 2.54.0