Re: [PATCH] usb: renesas_usbhs: Check pipe allocation in host pipe init

[Greg KH <gregkh@linuxfoundation.org>]

On Mon, Jun 22, 2026 at 07:45:21PM +0800, Haoxiang Li wrote:
> usbhsh_pipe_init_for_host() allocates pipes with usbhs_dcp_malloc()
> or usbhs_pipe_malloc(), both of which may return NULL. The returned
> pointer is dereferenced unconditionally when clearing pipe->mod_private.
> 
> Check the returned pipe before using it to avoid a NULL pointer
> dereference on pipe allocation/setup failure.
> 
> Signed-off-by: Haoxiang Li <haoxiang_li2024@163.com>
> ---
>  drivers/usb/renesas_usbhs/mod_host.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/usb/renesas_usbhs/mod_host.c b/drivers/usb/renesas_usbhs/mod_host.c
> index f7ef3a9f82a4..11244cf3408d 100644
> --- a/drivers/usb/renesas_usbhs/mod_host.c
> +++ b/drivers/usb/renesas_usbhs/mod_host.c
> @@ -1441,6 +1441,9 @@ static void usbhsh_pipe_init_for_host(struct usbhs_priv *priv)
>  						 dir_in);
>  		}
>  
> +		if (!pipe)
> +			return;

No, you just leaked memory and caused the system to be in an unknown
state, which is probably worse off than the crash that would have
happened.

Please fix this properly, if you really have ever hit this before.

thanks,

greg k-h