From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from flow-a8-smtp.messagingengine.com (flow-a8-smtp.messagingengine.com [103.168.172.143]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1836518871F; Mon, 29 Jun 2026 23:58:21 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=103.168.172.143 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782777504; cv=none; b=emT2c/1XRTQA4nYwBB210PbZwDn4Zr7TsPCfpx/aZBXIcg/qV3jS1qjOP488mlerCzjU/TQFGePENg6TdB/tVN7oHIdgHotoaekishfnxjd82RGoz0iu47uR4cRVBNmjOiCuSBemRWyRBdX/H5h/1SK3wIfaOz+NWWiRjiKKmI8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782777504; c=relaxed/simple; bh=qx9osW3wKKlKpE0YvFkVp52jSRf+weom0e3+8EbHzJg=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=PSNUouzR0lUnJ8+TdOrAqv5ol1qwFlX5yRnbW3xPodh/UECFd+A5m0XM8xFtxyFUEkk8gV2X9DBUU0hAZuwsvDBEvGE9c4/S+Hj2qQ5LsnPPFDgE9r1BEZhJ7hxLUL7sHYe4lYDyU/3ds19k9mkG1RqNK8bPanZd9nZdl8h8q7U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp; spf=pass smtp.mailfrom=sakamocchi.jp; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b=v8s/eY4L; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b=RMKRqs/f; arc=none smtp.client-ip=103.168.172.143 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sakamocchi.jp Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sakamocchi.jp header.i=@sakamocchi.jp header.b="v8s/eY4L"; dkim=pass (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="RMKRqs/f" Received: from phl-compute-05.internal (phl-compute-05.internal [10.202.2.45]) by mailflow.phl.internal (Postfix) with ESMTP id 0BA48138039B; Mon, 29 Jun 2026 19:58:21 -0400 (EDT) Received: from phl-frontend-03 ([10.202.2.162]) by phl-compute-05.internal (MEProxy); Mon, 29 Jun 2026 19:58:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sakamocchi.jp; h=cc:cc:content-transfer-encoding:content-type:content-type :date:date:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:subject:subject:to:to; s=fm1; t=1782777501; x=1782784701; bh=ntoVNrERxl6CnLB0Obl/d+Xz+xme4tJI lufgMOjhiwA=; b=v8s/eY4L5HFOcjqnQZ823UAS/LHyaUEm85qu0XmCc71uXnG2 cvkOxCYPzFLBCTTDnPAcBSYZzJ2+yE6N4fPa6sEGIBJIYZcOAN8qpj2nfzQLi9F5 jV1vvPyEhEYVlWNvh8/BzDIhVuyYzX2LsFle0pATeuiAfDmcO3X28y0E1iNUPJEo v25JyyyfCNSgY9W7bLDK2Py5B4SD2vS47HoLtwLlZyt9XfpB5i8DFFy195aCWoC2 x+AKL61GGQIyWrIINs+YyoIPvM9+DgmiU0kab1MThff7LoEH0Es/Wytho4Ztqxwh iCSNYBGhKHSWeVvvsd1OdF/pOZcK2ttl+46V3A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t=1782777501; x= 1782784701; bh=ntoVNrERxl6CnLB0Obl/d+Xz+xme4tJIlufgMOjhiwA=; b=R MKRqs/flHUni4dlOeHuhwjnnYx/qu2zwQCJtPfIIEPz3gE6dP2SS+kO/SxtUM2p+ fXsMgk2rDlTf/sTkRba30Ghras5RPXULAH1/GPHEEhmblWPHjyqELBYhA/qibNmQ ECYEK6oVYBifehsJjj32qWlobcGKFSrZa0HHgz9Iqwgpdu9YvkzR7VNNHw/jTwz+ bqoNgLB8cMrHpQ6+9NaoaPyDNO4HCQS72/HZv8UteAS8Rigl8p00Y6G1kFdS+1jK 6qPb3zwn5qYMTokX9EPzqE5AEbRmeo/zQ0VssHNfuoJG0EVsyiXKgURmOHD0sUV1 H0rRl8dpjOEVmRoTwUZ1Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: dmFkZTE1nPznX32V2kRYPd7dlOJ1rQMxQ97lS3kACD5+oEF3K9KIS5kEvZ60kMOO9SW4/K QPw1fJ0Uyhmt7TDZBpmrns6QqSMdNA56CqP8WoSfum8fnJ6ROXsuIW1V0IRazJ9YoofPdA sTTZjseo2amkBTK2yB8676gAjYCnTj4WiXvzDEoqMGHljUjgOtAHWVMwabts+S3qWRtyzK 4E9/EeTGdZ7uavjZ/gsD8IHy6BDQ3FsBKJrzbjVNgjW3Z/maBbDFLwVIvKVTB+FB58t2Nf 6IC6zRUoalXGvpiS7NeraM3cciwz14beoWbfR17QqVpm8xj9z6j1i325oVQMRhakNlULd5 LZDHjkZMhVaJOCK5sNu7C567TC6G74BcKbIUFX8Y7L5R/J5HFqJpTz5QFRAfF6pNDZXMRw NNT721SX2qmWOzpsbLjvz7baHpP6tE5XnMymltgojO/d+aMQ8ZSVKdM2OoEzaoH016syXZ LXR91cDsgFgly6bjeAUpymfC5EHpfadwr1qHn8fxadSgempnoWd6aBNScmoRMpmKbMNqfw SOO/eYhVEtRjJvkDcQZ5ZyEDYkQzi3vZqOB51rSkn6prTNuNuxVGEjwdaA6cQo5MEz4nhz PKvXIWkmhe258dVI/0CMIo7RXUSN9DEF8/fLk8wWAe6GpwU+34F0ICv2ylcg X-ME-Proxy: Feedback-ID: ie8e14432:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 29 Jun 2026 19:58:06 -0400 (EDT) Date: Tue, 30 Jun 2026 08:58:04 +0900 From: Takashi Sakamoto To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig_=28The_Capable_Hub=29?= Cc: Linus Torvalds , Greg Kroah-Hartman , Mark Brown , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Raag Jadav , Sohil Mehta , Dave Hansen , Rob Herring , Saravana Kannan , Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , Andi Shyti , linux-kernel@vger.kernel.org, Yemike Abhilash Chandra , Mauro Carvalho Chehab , linux-media@vger.kernel.org, Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , linux-rockchip@lists.infradead.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Danilo Krummrich , driver-core@lists.linux.dev, Jonathan Cameron , Dmitry Torokhov , Bartosz Golaszewski , Pei Xiao , Shashank Balaji , Ben Horgan , Johan Hovold , linux-usb@vger.kernel.org, Nikita Kravets , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , platform-driver-x86@vger.kernel.org, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, Daniel Scally , Sakari Ailus , Minas Harutyunyan , Tianrui Zhao , Bibo Mao , Huacai Chen , WANG Xuerui , kvm@vger.kernel.org, loongarch@lists.linux.dev Subject: Re: [PATCH v3 00/16] mod_devicetable.h: Split into per subsystem headers Message-ID: <20260629235804.GA414914@sakamocchi.jp> Mail-Followup-To: Takashi Sakamoto , Uwe =?iso-8859-1?Q?Kleine-K=F6nig_=28The_Capable_Hub=29?= , Linus Torvalds , Greg Kroah-Hartman , Mark Brown , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , Raag Jadav , Sohil Mehta , Dave Hansen , Rob Herring , Saravana Kannan , Bjorn Helgaas , "Rafael J. Wysocki" , Len Brown , Andi Shyti , linux-kernel@vger.kernel.org, Yemike Abhilash Chandra , Mauro Carvalho Chehab , linux-media@vger.kernel.org, Nicolas Frattaroli , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Heiko Stuebner , linux-rockchip@lists.infradead.org, linux-sound@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Danilo Krummrich , driver-core@lists.linux.dev, Jonathan Cameron , Dmitry Torokhov , Bartosz Golaszewski , Pei Xiao , Shashank Balaji , Ben Horgan , Johan Hovold , linux-usb@vger.kernel.org, Nikita Kravets , Hans de Goede , Ilpo =?iso-8859-1?Q?J=E4rvinen?= , platform-driver-x86@vger.kernel.org, devicetree@vger.kernel.org, linux-i2c@vger.kernel.org, Daniel Scally , Sakari Ailus , Minas Harutyunyan , Tianrui Zhao , Bibo Mao , Huacai Chen , WANG Xuerui , kvm@vger.kernel.org, loongarch@lists.linux.dev References: Precedence: bulk X-Mailing-List: linux-usb@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: Hi, On Sun, Jun 28, 2026 at 11:58:35PM +0200, Uwe Kleine-König (The Capable Hub) wrote: > Hello, > > v2 is available at > https://lore.kernel.org/lkml/cover.1782490566.git.u.kleine-koenig@baylibre.com > . > > Changes since then: > > - rebased to v7.2-rc1 > - rename the directory containing the new per device-id headers from > "mod_device_id" to "device-id". > - Adding Acks received > - ASoC patch (formerly patch #3) dropped as it was already merged as > commit 83d53eca7e55 ("ASoC: rockchip: rockchip_sai: #include > explicitly") in v7.2-rc1. > > This series survived an allmodconfig build on alpha, arc, arm64, > loongarch, m68k, mips, powerpc, riscv, s390, sh, sparc, and x86_64. > (Well, some failures, but I see these also on vanilla v7.2-rc1.) > > There are a few headers left that include , but > these can be addressed in the next dev cycle without much impact as all > the much included headers are covered here. > > I will apply this series to > > https://git.kernel.org/pub/scm/linux/kernel/git/ukleinek/linux.git device-id-rework > > which is included in next to expose it to the build bots and testers (in > the hope that there won't occur much merge conflict with v7.3 material). > I will add review tags and address (the hopefully very few) build issues > that might pop up. My plan is to let Linus merge it end of the week for > -rc2. > > Best regards > Uwe > > Uwe Kleine-König (The Capable Hub) (16): > mod_devicetable.h: Split into per subsystem headers > media: ti: vpe: #include explicitly > driver: core: Include headers for acpi_device_id and of_device_id for > struct device_driver > driver core: platform: Include header for struct platform_device_id > usb: serial: Include in > platform/x86: msi-ec: Ensure dmi_system_id is defined > of: Explicitly include and > i2c: Let i2c-core.h include > platform/x86: x86-android-tablets: Add include defining struct > dmi_system_id > platform/x86: int3472: Add include defining struct dmi_system_id > usb: dwc2: Add include defining struct pci_device_id > ALSA: hda/core: Add include defining struct hda_device_id > LoongArch: KVM: Add include defining struct cpu_feature > media: em28xx: Add include for struct usb_device_id > Replace by more specific > (headers) > Replace by more specific > (c files) > > ... > drivers/firewire/core-device.c | 1 - > drivers/firewire/net.c | 1 - > drivers/firewire/sbp2.c | 1 - > ... > drivers/media/firewire/firedtv-fw.c | 1 - > ... > include/linux/firewire.h | 3 +- > ... > sound/firewire/isight.c | 1 - > ... > 1649 files changed, 1575 insertions(+), 2544 deletions(-) > ... > create mode 100644 include/linux/device-id/ieee1394.h I have no objection to the above changes relevant to firewire subsystem. Acked-by: Takashi Sakamoto Consequently, unit drivers just include include/linux/firewire.h to refer to 'struct ieee1394_device_id'. After merging the changes, I'll post more patches to modify the following unit drivers, since they are left from the patchset. * drivers/media/firewire/firedtv.h * sound/firewire/bebob/bebob.h * sound/firewire/dice/dice.h * sound/firewire/digi00x/digi00x.h * sound/firewire/fireface/ff.h * sound/firewire/fireworks/fireworks.h * sound/firewire/motu/motu.h * sound/firewire/oxfw/oxfw.h * sound/firewire/tascam/tascam.h By the way, the changes touch so many files. If it takes more time to apply, I think it better to make steps to modify across several kernel generation. For example, getting rid of direct reference of mod_devicetable.h from drivers at first (in the case of firewire subsystem, for 'Replace by more specific (headers))', then adding these per-subsystem headers and applying relevant changes. Of course, I don't mind to apply the v3 patchset as is in upstream. Thanks Takashi Sakamoto