From: Greg KH <gregkh@linuxfoundation.org>
To: raoxu <raoxu@uniontech.com>
Cc: valentina.manea.m@gmail.com, shuah@kernel.org, i@zenithal.me,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH] usbip: vudc: fix NULL pointer dereference in vep_dequeue()
Date: Thu, 2 Jul 2026 10:38:25 +0200 [thread overview]
Message-ID: <2026070215-parted-cloak-7fb0@gregkh> (raw)
In-Reply-To: <2B1E59F5E4C6B935+20260702081232.2477777-1-raoxu@uniontech.com>
On Thu, Jul 02, 2026 at 04:12:32PM +0800, raoxu wrote:
> From: Xu Rao <raoxu@uniontech.com>
>
> vep_alloc_request() zero-initializes struct vrequest but never assigns
> vrequest::udc. vep_dequeue() then reads that field and dereferences it
> while checking udc->driver. Consequently, any usb_ep_dequeue() call that
> reaches the vUDC dequeue operation can crash the kernel.
>
> The endpoint passed to ->dequeue() identifies both the request queue
> being searched and the owning vUDC. Derive the controller from that
> endpoint with ep_to_vudc(), as the other endpoint operations do.
>
> After this change, vrequest::udc has no users. Remove the redundant
> controller backpointer.
>
> Fixes: b6a0ca111867 ("usbip: vudc: Add UDC specific ops")
> Signed-off-by: Xu Rao <raoxu@uniontech.com>
> ---
> drivers/usb/usbip/vudc.h | 1 -
> drivers/usb/usbip/vudc_dev.c | 4 +---
> 2 files changed, 1 insertion(+), 4 deletions(-)
Why is this a RESEND?
prev parent reply other threads:[~2026-07-02 8:44 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-02 8:12 [RESEND PATCH] usbip: vudc: fix NULL pointer dereference in vep_dequeue() raoxu
2026-07-02 8:38 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026070215-parted-cloak-7fb0@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=i@zenithal.me \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=raoxu@uniontech.com \
--cc=shuah@kernel.org \
--cc=valentina.manea.m@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox